Bug 83983

Summary:	FILEOPEN: Regression in 4.4 master loading an ODT which contains a style with style:font-independent-line-spacing="true"
Product:	LibreOffice	Reporter:	Matthew Francis <fdbugs>
Component:	filters and storage	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---	QA Contact:
Severity:	major
Priority:	high	CC:	anistenis, fdbugs, serval2412
Version:	4.4.0.0.alpha0+ Master	Keywords:	bisected, regression
Hardware:	Other
OS:	All
Whiteboard:	bibisected
i915 platform:		i915 features:
Attachments:	Minimised example (see comment #0 for link to original document)

Description Matthew Francis 2014-09-17 11:58:33 UTC

The following file loads and displays correctly in LO 4.3.0.1, but fails to load at all in 4.4 master (observed on both OSX and Linux):

https://bugs.freedesktop.org/attachment.cgi?id=106116
(from bug 83755)



On 4.4 master, instead of loading, it throws up a dialog containing:

"Read-Error. Error reading file."

and outputs the following console log message (in a debug build):

warn:legacy.osl:25295:1:sw/source/filter/xml/swxml.cxx:268: uno exception caught while importing:
Unknown property: FontIndependentLineSpacing



The offending XML within the ODT appears to be this:

<style:paragraph-properties ..... style:font-independent-line-spacing="true"/>

(see the attached minimised example, which likewise loads in 4.3.0.1 but not 4.4 master)



Bisecting backwards, the dialog starts to appear as of:

commit b0f54746be824343379ea957d4220102e14c0f75
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Fri Jul 18 13:38:25 2014 +0100

    coverity#1224992 Uncaught exception



However, this is not the cause of the bug, but merely converts a fatal exception into a non-fatal error. Further back, the actual failure to load is introduced by:


commit 7d9bb549d498d6beed2c4050c402d09643febdfa
Author: Armin Le Grand <alg@apache.org>
Date:   Mon Jun 2 15:00:50 2014 +0000

    Related: #i124638# Second step of DrawingLayer FillAttributes...


Even before this commit, there is a further issue that the rendering of the original document is no longer correct. I haven't narrowed down exactly where that broke.

Comment 1 Matthew Francis 2014-09-17 11:59:52 UTC

Created attachment 106424 [details]
Minimised example (see comment #0 for link to original document)

Comment 2 Julien Nabet 2014-09-17 20:23:22 UTC

On pc Debian x86-64 with master sources updated today, I could reproduce this.

Comment 3 Julien Nabet 2014-09-17 21:17:01 UTC

Trying to gdb it, I saw that there's a parsing problem indicated by:
http://opengrok.libreoffice.org/xref/core/sax/source/expatwrap/sax_expat.cxx#700
bExceptionWasThrown = true
But then I'm a bit lost.

Comment 4 Miklos Vajna 2014-09-24 15:52:44 UTC

If this is a regression, please add "regression" to keywords.

Comment 5 Xisco Faulí 2014-10-23 14:55:31 UTC

It seems that the commit that caused this regression was identified. (Or at
least a commit is suspected as the offending one.)

Thus setting keyword "bisected".

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.