Bug 84091

Summary:	Add asynchronous api for user uncaching
Product:	accountsservice	Reporter:	Ondrej Holy <oholy>
Component:	general	Assignee:	Matthias Clasen <mclasen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	marius.vollmer, rstrode, stefw
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	add asynchronous api for user uncaching

Description Ondrej Holy 2014-09-19 12:02:41 UTC

Created attachment 106545 [details] [review]
add asynchronous api for user uncaching

The asynchrounous api is needed for deleting enterprise accounts in gnome control center, see:
https://bugzilla.gnome.org/show_bug.cgi?id=727871

Comment 1 Stef Walter 2014-09-19 12:31:24 UTC

Comment on attachment 106545 [details] [review]
add asynchronous api for user uncaching

Review of attachment 106545 [details] [review]:
-----------------------------------------------------------------

Looks good to me.

::: src/libaccountsservice/act-user-manager.c
@@ +3379,5 @@
> +{
> +        GSimpleAsyncResult *res;
> +
> +        g_return_if_fail (ACT_IS_USER_MANAGER (manager));
> +        g_return_if_fail (manager->priv->accounts_proxy != NULL);

Perhaps a check that username != NULL?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.