Bug 84091 - Add asynchronous api for user uncaching
Summary: Add asynchronous api for user uncaching
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-19 12:02 UTC by Ondrej Holy
Modified: 2014-09-30 14:17 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
add asynchronous api for user uncaching (5.36 KB, patch)
2014-09-19 12:02 UTC, Ondrej Holy 		Details | Splinter Review
View All

Description Ondrej Holy 2014-09-19 12:02:41 UTC 
Created attachment 106545 [details] [review]
add asynchronous api for user uncaching

The asynchrounous api is needed for deleting enterprise accounts in gnome control center, see:
https://bugzilla.gnome.org/show_bug.cgi?id=727871
Comment 1 Stef Walter 2014-09-19 12:31:24 UTC 
Comment on attachment 106545 [details] [review]
add asynchronous api for user uncaching

Review of attachment 106545 [details] [review]:
-----------------------------------------------------------------

Looks good to me.

::: src/libaccountsservice/act-user-manager.c
@@ +3379,5 @@
> +{
> +        GSimpleAsyncResult *res;
> +
> +        g_return_if_fail (ACT_IS_USER_MANAGER (manager));
> +        g_return_if_fail (manager->priv->accounts_proxy != NULL);

Perhaps a check that username != NULL?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.