| Summary: | update Korean layouts - adding an option | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Changwoo Ryu <cwryu> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | kurt |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 71696 | ||
| Attachments: | proposed patch; update Korean | ||
I am confused. You are using the section "kr(hw_keys)" but where is it? I see that only in sun_vndr/kr, not in the main kr file. *** Bug 71696 has been marked as a duplicate of this bug. *** It is in the symbols/kr file. Renamed from old "koreankeys" for more clarification.
diff --git a/symbols/kr b/symbols/kr
index 1ee560b..e554af0 100644
--- a/symbols/kr
+++ b/symbols/kr
@@ -2,27 +2,53 @@ default alphanumeric_keys
xkb_symbols "kr106" {
include "us"
name[Group1]= "Korean";
- include "kr(koreankeys)"
+ include "kr(hw_keys)"
};
alphanumeric_keys
xkb_symbols "kr104" {
include "us"
name[Group1]= "Korean (101/104 key compatible)";
- include "kr(koreankeys)"
- include "kr(koreankeys_raltctl)"
+ include "kr(ralt_hangul)"
+ include "kr(rctrl_hanja)"
};
-hidden partial function_keys
-xkb_symbols "koreankeys" {
- key <K71> { [ Hangul ] };
- key <K72> { [ Hangul_Hanja ] };
+partial function_keys
+xkb_symbols "hw_keys" {
+ key <HNGL> { [ Hangul ] };
+ key <HJCV> { [ Hangul_Hanja ] };
};
Thank you, I did not notice that. Committed! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 106972 [details] proposed patch; update Korean Please update Korean related xkb data with this patch: The problem of the current kr layouts (written by me) is, they assume US QWERTY layout. So Korean Dvorak/Colemak users couldn't use Korean key settings. So for more flexibility, I've decided to make the Korean key settings as selectable options, rather than fixed layouts. This patch adds a new option, "Korean Hangul/Hanja keys". Existing "kr" layout and "kr(kr104)" variant still remain as US QWERTY based ones.