Bug 84404 - update Korean layouts - adding an option
Summary: update Korean layouts - adding an option
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
: 71696 (view as bug list)
Depends on:
Blocks: 71696
  Show dependency treegraph
 
Reported: 2014-09-27 21:44 UTC by Changwoo Ryu
Modified: 2015-01-15 01:14 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
proposed patch; update Korean (4.63 KB, text/plain)
2014-09-27 21:44 UTC, Changwoo Ryu
Details

Description Changwoo Ryu 2014-09-27 21:44:38 UTC
Created attachment 106972 [details]
proposed patch; update Korean

Please update Korean related xkb data with this patch:

The problem of the current kr layouts (written by me) is, they assume US QWERTY layout. So Korean Dvorak/Colemak users couldn't use Korean key settings.

So for more flexibility, I've decided to make the Korean key settings as selectable options, rather than fixed layouts.

This patch adds a new option, "Korean Hangul/Hanja keys". Existing "kr" layout and "kr(kr104)" variant still remain as US QWERTY based ones.
Comment 1 Sergey V. Udaltsov 2014-12-10 00:04:57 UTC
I am confused. You are using the section "kr(hw_keys)" but where is it? I see that only in sun_vndr/kr, not in the main kr file.
Comment 2 Sergey V. Udaltsov 2014-12-10 00:15:26 UTC
*** Bug 71696 has been marked as a duplicate of this bug. ***
Comment 3 Changwoo Ryu 2014-12-10 05:48:55 UTC
It is in the symbols/kr file. Renamed from old "koreankeys" for more clarification.


diff --git a/symbols/kr b/symbols/kr
index 1ee560b..e554af0 100644
--- a/symbols/kr
+++ b/symbols/kr
@@ -2,27 +2,53 @@ default  alphanumeric_keys
 xkb_symbols "kr106" {
     include "us"
     name[Group1]= "Korean";
-    include "kr(koreankeys)"
+    include "kr(hw_keys)"
 };
 
 alphanumeric_keys
 xkb_symbols "kr104" {
     include "us"
     name[Group1]= "Korean (101/104 key compatible)";
-    include "kr(koreankeys)"
-    include "kr(koreankeys_raltctl)"
+    include "kr(ralt_hangul)"
+    include "kr(rctrl_hanja)"
 };
 
-hidden partial function_keys
-xkb_symbols "koreankeys" {
-    key <K71> { [ Hangul ] };
-    key <K72> { [ Hangul_Hanja ] };
+partial function_keys
+xkb_symbols "hw_keys" {
+    key <HNGL> { [ Hangul       ] };
+    key <HJCV> { [ Hangul_Hanja ] };
 };
Comment 4 Sergey V. Udaltsov 2015-01-15 01:14:14 UTC
Thank you, I did not notice that. Committed!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.