Bug 84607

Summary:	Dict.remove memory leak
Product:	poppler	Reporter:	Scott West <scott.gregory.west>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch to free removed entries.

Description Scott West 2014-10-02 21:21:20 UTC

Created attachment 107238 [details]
Patch to free removed entries.

It looks like Dict.remove just copies over the entries that it removes, and thus doesn't free the key or the object associated with the entry. This is a memory leak.

The attached patch should fix that.

Comment 1 Albert Astals Cid 2014-10-07 21:07:16 UTC

Wouldn't this crash if the entry does not exist?

Comment 2 Albert Astals Cid 2014-10-07 21:54:22 UTC

Yeah it would, so i've fixed it and commited the fixed patch. Thanks :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.