Bug 84607 - Dict.remove memory leak
Summary: Dict.remove memory leak
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-02 21:21 UTC by Scott West
Modified: 2014-10-07 21:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch to free removed entries. (1.31 KB, text/plain)
2014-10-02 21:21 UTC, Scott West 		Details
View All

Description Scott West 2014-10-02 21:21:20 UTC 
Created attachment 107238 [details]
Patch to free removed entries.

It looks like Dict.remove just copies over the entries that it removes, and thus doesn't free the key or the object associated with the entry. This is a memory leak.

The attached patch should fix that.
Comment 1 Albert Astals Cid 2014-10-07 21:07:16 UTC 
Wouldn't this crash if the entry does not exist?
Comment 2 Albert Astals Cid 2014-10-07 21:54:22 UTC 
Yeah it would, so i've fixed it and commited the fixed patch. Thanks :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.