Bug 85178

Summary: checks for system secure_getenv, but never uses it
Product: p11-glue Reporter: Andreas Metzler <ametzler>
Component: p11-kitAssignee: Stef Walter <stefw>
Status: NEW --- QA Contact:
Severity: normal    
Priority: medium CC: ametzler
Version: unspecified   
Hardware: Other   
OS: All   
i915 platform: i915 features:

Description Andreas Metzler 2014-10-18 16:46:51 UTC

p11-kit's ./configure checks for secure_getenv()

AC_CHECK_FUNCS([getauxval issetugid getresuid secure_getenv])

However no matter whether it exists or not the p11-kit version in a compat.c is always used instead of the system one.

I /think/ that the only system providing secure_getenv() is glibc, however only if _GNU_SOURCE is set. Given that p11-kit contains code to prevent compilation with _GNU_SOURCE there does not seem to be any point in AC_CHECK_FUNCS([secure_getenv]) and modifying p11-kit's code to use the system version if available. How about dropping this check?

cu Andreas

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.