Bug 85178 - checks for system secure_getenv, but never uses it
Summary: checks for system secure_getenv, but never uses it
Status: NEW
Alias: None
Product: p11-glue
Classification: Unclassified
Component: p11-kit (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-18 16:46 UTC by Andreas Metzler
Modified: 2014-10-18 16:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Andreas Metzler 2014-10-18 16:46:51 UTC 
Hello,

p11-kit's ./configure checks for secure_getenv()

AC_CHECK_FUNCS([getauxval issetugid getresuid secure_getenv])

However no matter whether it exists or not the p11-kit version in a compat.c is always used instead of the system one.

I /think/ that the only system providing secure_getenv() is glibc, however only if _GNU_SOURCE is set. Given that p11-kit contains code to prevent compilation with _GNU_SOURCE there does not seem to be any point in AC_CHECK_FUNCS([secure_getenv]) and modifying p11-kit's code to use the system version if available. How about dropping this check?

cu Andreas

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.