Summary: | make dist is broken | ||
---|---|---|---|
Product: | poppler | Reporter: | Albert Astals Cid <aacid> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | hib |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Do not distribute .moc files |
Description
Albert Astals Cid
2014-11-03 20:39:48 UTC
Hib, you changed that Makefile.am to make it better. I need you to fix it to make it work. This files should not be dist-ed ./poppler-0.28.0/qt5/demos/thumbnails.moc ./poppler-0.28.0/qt5/demos/toc.moc ./poppler-0.28.0/qt5/demos/embeddedfiles.moc ./poppler-0.28.0/qt5/demos/permissions.moc ./poppler-0.28.0/qt5/demos/optcontent.moc ./poppler-0.28.0/qt5/demos/navigationtoolbar.moc ./poppler-0.28.0/qt5/demos/metadata.moc ./poppler-0.28.0/qt5/demos/info.moc ./poppler-0.28.0/qt5/demos/viewer.moc ./poppler-0.28.0/qt5/demos/fonts.moc ./poppler-0.28.0/qt5/demos/abstractinfodock.moc ./poppler-0.28.0/qt5/demos/pageview.moc ./poppler-0.28.0/qt4/demos/thumbnails.moc ./poppler-0.28.0/qt4/demos/toc.moc ./poppler-0.28.0/qt4/demos/embeddedfiles.moc ./poppler-0.28.0/qt4/demos/permissions.moc ./poppler-0.28.0/qt4/demos/optcontent.moc ./poppler-0.28.0/qt4/demos/navigationtoolbar.moc ./poppler-0.28.0/qt4/demos/metadata.moc ./poppler-0.28.0/qt4/demos/info.moc ./poppler-0.28.0/qt4/demos/viewer.moc ./poppler-0.28.0/qt4/demos/fonts.moc ./poppler-0.28.0/qt4/demos/abstractinfodock.moc ./poppler-0.28.0/qt4/demos/pageview.moc i will look into it now. Created attachment 108865 [details] [review] Do not distribute .moc files There also seems to be an erorr in glib, working on that now. in poppler-enums.c Do we even need BUILT_SOURCES now? (In reply to Albert Astals Cid from comment #7) > Do we even need BUILT_SOURCES now? I think yes, it specfies that building of the moc files should happen before the .cc files (that need them) are compiled. (In reply to Hib Eris from comment #5) > There also seems to be an erorr in glib, working on that now. > poppler-enums.c There is a problem with including poppler-action.h in the generated poppler-enums.c, but this problem only happens when 'make dist' was run out of source. So as long as you run 'make dist' from within the source tree, there is no problem. Awesome thanks :) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.