Bug 85821 - make dist is broken
Summary: make dist is broken
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 20:39 UTC by Albert Astals Cid
Modified: 2014-11-04 00:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Do not distribute .moc files (1013 bytes, patch)
2014-11-03 21:49 UTC, Hib Eris
Details | Splinter Review

Description Albert Astals Cid 2014-11-03 20:39:48 UTC
.moc files are included when they didn't use to get included. This breaks compilation in out of source builds.
Comment 1 Albert Astals Cid 2014-11-03 20:40:26 UTC
Hib, you changed that Makefile.am to make it better. 

I need you to fix it to make it work.
Comment 2 Albert Astals Cid 2014-11-03 20:41:41 UTC
This files should not be dist-ed

./poppler-0.28.0/qt5/demos/thumbnails.moc
./poppler-0.28.0/qt5/demos/toc.moc
./poppler-0.28.0/qt5/demos/embeddedfiles.moc
./poppler-0.28.0/qt5/demos/permissions.moc
./poppler-0.28.0/qt5/demos/optcontent.moc
./poppler-0.28.0/qt5/demos/navigationtoolbar.moc
./poppler-0.28.0/qt5/demos/metadata.moc
./poppler-0.28.0/qt5/demos/info.moc
./poppler-0.28.0/qt5/demos/viewer.moc
./poppler-0.28.0/qt5/demos/fonts.moc
./poppler-0.28.0/qt5/demos/abstractinfodock.moc
./poppler-0.28.0/qt5/demos/pageview.moc
./poppler-0.28.0/qt4/demos/thumbnails.moc
./poppler-0.28.0/qt4/demos/toc.moc
./poppler-0.28.0/qt4/demos/embeddedfiles.moc
./poppler-0.28.0/qt4/demos/permissions.moc
./poppler-0.28.0/qt4/demos/optcontent.moc
./poppler-0.28.0/qt4/demos/navigationtoolbar.moc
./poppler-0.28.0/qt4/demos/metadata.moc
./poppler-0.28.0/qt4/demos/info.moc
./poppler-0.28.0/qt4/demos/viewer.moc
./poppler-0.28.0/qt4/demos/fonts.moc
./poppler-0.28.0/qt4/demos/abstractinfodock.moc
./poppler-0.28.0/qt4/demos/pageview.moc
Comment 3 Hib Eris 2014-11-03 21:12:30 UTC
i will look into it now.
Comment 4 Hib Eris 2014-11-03 21:49:33 UTC
Created attachment 108865 [details] [review]
Do not distribute .moc files
Comment 5 Hib Eris 2014-11-03 22:00:44 UTC
There also seems to be an erorr in glib, working on that now.
Comment 6 Hib Eris 2014-11-03 22:03:41 UTC
in poppler-enums.c
Comment 7 Albert Astals Cid 2014-11-03 22:05:02 UTC
Do we even need BUILT_SOURCES now?
Comment 8 Hib Eris 2014-11-03 22:42:47 UTC
(In reply to Albert Astals Cid from comment #7)
> Do we even need BUILT_SOURCES now?

I think yes, it specfies that building of the moc files should happen before the .cc files (that need them) are compiled.
Comment 9 Hib Eris 2014-11-03 22:46:56 UTC
(In reply to Hib Eris from comment #5)
> There also seems to be an erorr in glib, working on that now.
> poppler-enums.c

There is a problem with including poppler-action.h in the generated poppler-enums.c, but this problem only happens when 'make dist' was run out of source.

So as long as you run 'make dist' from within the source tree, there is no problem.
Comment 10 Albert Astals Cid 2014-11-04 00:26:22 UTC
Awesome thanks :)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.