Bug 8788

Summary: Recursive adding of cflags only goes down one level with requires.private
Product: pkg-config Reporter: Tom Parker <freedesktop>
Component: srcAssignee: Tollef Fog Heen <tfheen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: rdieter
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Corrects the behaviour
the right fix

Description Tom Parker 2006-10-27 03:28:37 UTC 
The changelog for 0.21 mentions "Always add all cflags.  Debian #340904".
However, this only works down one level when requires.private is in place. e.g.
package A has a requires.private for package B which has a requires for package
C. Doing "pkg-config --cflags A" will only get the flags for A and B, but not C.
Switching A's requires.private to a requires fixes this, but changing B's
requires to a requires.private does nothing.
Comment 1 Tom Parker 2006-10-27 15:00:40 UTC 
Created attachment 7561 [details] [review]
Corrects the behaviour
Comment 2 Matthias Clasen 2007-03-29 21:39:58 UTC 
Created attachment 9374 [details] [review]
the right fix
Comment 3 Tollef Fog Heen 2007-06-19 05:35:42 UTC 
2007-06-18  Tollef Fog Heen  <tfheen@err.no>

        * pkg.c (recursive_fill_list): Make sure to act recursively with
        Requires.private, making them much more useful.  Special thanks to
        Matthias Clasen for lots and lots of nagging.  Freedesktop #8788

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.