Bug 8788 - Recursive adding of cflags only goes down one level with requires.private
Summary: Recursive adding of cflags only goes down one level with requires.private
Alias: None
Product: pkg-config
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Tollef Fog Heen
QA Contact:
Depends on:
Reported: 2006-10-27 03:28 UTC by Tom Parker
Modified: 2007-06-19 05:35 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Corrects the behaviour (1.17 KB, patch)
2006-10-27 15:00 UTC, Tom Parker
Details | Splinter Review
the right fix (291 bytes, patch)
2007-03-29 21:39 UTC, Matthias Clasen
Details | Splinter Review

Description Tom Parker 2006-10-27 03:28:37 UTC
The changelog for 0.21 mentions "Always add all cflags.  Debian #340904".
However, this only works down one level when requires.private is in place. e.g.
package A has a requires.private for package B which has a requires for package
C. Doing "pkg-config --cflags A" will only get the flags for A and B, but not C.
Switching A's requires.private to a requires fixes this, but changing B's
requires to a requires.private does nothing.
Comment 1 Tom Parker 2006-10-27 15:00:40 UTC
Created attachment 7561 [details] [review]
Corrects the behaviour
Comment 2 Matthias Clasen 2007-03-29 21:39:58 UTC
Created attachment 9374 [details] [review]
the right fix
Comment 3 Tollef Fog Heen 2007-06-19 05:35:42 UTC
2007-06-18  Tollef Fog Heen  <tfheen@err.no>

        * pkg.c (recursive_fill_list): Make sure to act recursively with
        Requires.private, making them much more useful.  Special thanks to
        Matthias Clasen for lots and lots of nagging.  Freedesktop #8788

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.