|
Description
Hib Eris
2015-01-25 18:06:04 UTC
Created attachment 112809 [details] [review] [glib] Remove deprecated use of gtk_tree_view_set_rules_hint() The use of rules-hint is deprecated in gtk because it is considered bad application API and is not really usefull. See https://git.gnome.org/browse/gtk+/commit/?id=0ed766ec866a2da7e3db05b1db2fc2519d6b1cdc Created attachment 112810 [details] [review] [glib] Remove use of deprecated GtkAlignment from demo/info.cc Created attachment 112811 [details] [review] [glib] Remove use of deprecated GtkAlignment from demo/forms.c Created attachment 112812 [details] [review] [glib] Remove use of deprecated GtkAlignment from demo/annots.c Created attachment 112813 [details] [review] [glib] Remove use of deprecated GtkAlignment from demo/page.c Created attachment 112814 [details] [review] [glib] Remove use of deprecated GtkAlignment from demo/text.c Created attachment 112815 [details] [review] [glib] Remove use of deprecated GtkAlignment from demo/utils.c Created attachment 112816 [details] [review] [glib] Remove use of deprecated GtkAlignment from demo/main.c Created attachment 112817 [details] [review] [glib] Remove deprecated use of gtk_misc_set_alignment() from demo/main.c Created attachment 117367 [details] [review] [glib] Remove use of deprecated gtk_dialog_set_alternative_button_order() Created attachment 117368 [details] [review] [glib] Remove code for no longer supported gtk versions Sorry for the delay reviewing this, I had forgotten these patches. I've just pushed them, squashing all the GtkAlignment ones together. Thanks! Hi Carlos, I notice you added additional fixes to my patch 'Remove use of deprecated GtkAlignment from demo/main.c' I think those extra fixes are not correct. Created attachment 117377 [details] [review] Prefer gtk_label_set_{x,y}align() over deprecated gtk_misc_set_alignment() Created attachment 117378 [details] [review] [glib] Partially revert ffc798a7 Created attachment 117379 [details] [review] Prefer gtk_label_set_{x,y}align() over deprecated gtk_misc_set_alignment() (In reply to Hib Eris from comment #13) > I notice you added additional fixes to my patch 'Remove use of deprecated > GtkAlignment from demo/main.c' Whoops, I meant: from my patch '[glib] Remove deprecated use of gtk_misc_set_alignment() from demo/main.c' Oh, sorry, I assumed those should work the same way. Squashed and pushed, thanks again. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.