Bug 88788 - Remove use of deprecated gtk functions
Summary: Remove use of deprecated gtk functions
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: glib frontend (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-25 18:06 UTC by Hib Eris
Modified: 2015-07-27 12:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[glib] Remove deprecated use of gtk_tree_view_set_rules_hint() (2.89 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated GtkAlignment from demo/info.cc (1.93 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated GtkAlignment from demo/forms.c (1.97 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated GtkAlignment from demo/annots.c (2.06 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated GtkAlignment from demo/page.c (3.23 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated GtkAlignment from demo/text.c (2.17 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated GtkAlignment from demo/utils.c (4.64 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated GtkAlignment from demo/main.c (1.44 KB, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove deprecated use of gtk_misc_set_alignment() from demo/main.c (896 bytes, patch)
2015-01-25 18:06 UTC, Hib Eris
Details | Splinter Review
[glib] Remove use of deprecated gtk_dialog_set_alternative_button_order() (898 bytes, patch)
2015-07-25 09:58 UTC, Hib Eris
Details | Splinter Review
[glib] Remove code for no longer supported gtk versions (3.32 KB, patch)
2015-07-25 09:59 UTC, Hib Eris
Details | Splinter Review
Prefer gtk_label_set_{x,y}align() over deprecated gtk_misc_set_alignment() (1.67 KB, patch)
2015-07-26 08:29 UTC, Hib Eris
Details | Splinter Review
[glib] Partially revert ffc798a7 (1.33 KB, patch)
2015-07-26 08:41 UTC, Hib Eris
Details | Splinter Review
Prefer gtk_label_set_{x,y}align() over deprecated gtk_misc_set_alignment() (1.42 KB, patch)
2015-07-26 08:42 UTC, Hib Eris
Details | Splinter Review

Description Hib Eris 2015-01-25 18:06:04 UTC

    
Comment 1 Hib Eris 2015-01-25 18:06:06 UTC
Created attachment 112809 [details] [review]
[glib] Remove deprecated use of gtk_tree_view_set_rules_hint()

The use of rules-hint is deprecated in gtk because it is
considered bad application API and is not really usefull.

See https://git.gnome.org/browse/gtk+/commit/?id=0ed766ec866a2da7e3db05b1db2fc2519d6b1cdc
Comment 2 Hib Eris 2015-01-25 18:06:09 UTC
Created attachment 112810 [details] [review]
[glib] Remove use of deprecated GtkAlignment from demo/info.cc
Comment 3 Hib Eris 2015-01-25 18:06:12 UTC
Created attachment 112811 [details] [review]
[glib] Remove use of deprecated GtkAlignment from demo/forms.c
Comment 4 Hib Eris 2015-01-25 18:06:14 UTC
Created attachment 112812 [details] [review]
[glib] Remove use of deprecated GtkAlignment from demo/annots.c
Comment 5 Hib Eris 2015-01-25 18:06:16 UTC
Created attachment 112813 [details] [review]
[glib] Remove use of deprecated GtkAlignment from demo/page.c
Comment 6 Hib Eris 2015-01-25 18:06:19 UTC
Created attachment 112814 [details] [review]
[glib] Remove use of deprecated GtkAlignment from demo/text.c
Comment 7 Hib Eris 2015-01-25 18:06:22 UTC
Created attachment 112815 [details] [review]
[glib] Remove use of deprecated GtkAlignment from demo/utils.c
Comment 8 Hib Eris 2015-01-25 18:06:25 UTC
Created attachment 112816 [details] [review]
[glib] Remove use of deprecated GtkAlignment from demo/main.c
Comment 9 Hib Eris 2015-01-25 18:06:28 UTC
Created attachment 112817 [details] [review]
[glib] Remove deprecated use of gtk_misc_set_alignment() from demo/main.c
Comment 10 Hib Eris 2015-07-25 09:58:14 UTC
Created attachment 117367 [details] [review]
[glib] Remove use of deprecated gtk_dialog_set_alternative_button_order()
Comment 11 Hib Eris 2015-07-25 09:59:31 UTC
Created attachment 117368 [details] [review]
[glib] Remove code for no longer supported gtk versions
Comment 12 Carlos Garcia Campos 2015-07-26 07:58:01 UTC
Sorry for the delay reviewing this, I had forgotten these patches. I've just pushed them, squashing all the GtkAlignment ones together. Thanks!
Comment 13 Hib Eris 2015-07-26 08:22:01 UTC
Hi Carlos,

I notice you added additional fixes to my patch 'Remove use of deprecated GtkAlignment from demo/main.c'

I think those extra fixes are not correct.
Comment 14 Hib Eris 2015-07-26 08:29:03 UTC
Created attachment 117377 [details] [review]
Prefer gtk_label_set_{x,y}align() over deprecated gtk_misc_set_alignment()
Comment 15 Hib Eris 2015-07-26 08:41:49 UTC
Created attachment 117378 [details] [review]
[glib] Partially revert ffc798a7
Comment 16 Hib Eris 2015-07-26 08:42:11 UTC
Created attachment 117379 [details] [review]
Prefer gtk_label_set_{x,y}align() over deprecated gtk_misc_set_alignment()
Comment 17 Hib Eris 2015-07-26 08:48:48 UTC
(In reply to Hib Eris from comment #13)

> I notice you added additional fixes to my patch 'Remove use of deprecated
> GtkAlignment from demo/main.c'

Whoops, I meant: from my patch '[glib] Remove deprecated use of gtk_misc_set_alignment() from demo/main.c'
Comment 18 Carlos Garcia Campos 2015-07-27 12:58:59 UTC
Oh, sorry, I assumed those should work the same way. Squashed and pushed, thanks again.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.