Bug 89011

Summary:	Install introspection and bus config schemas on system
Product:	dbus	Reporter:	Philip Withnall <bugzilla>
Component:	core	Assignee:	D-Bus Maintainers <dbus>
Status:	RESOLVED FIXED	QA Contact:	D-Bus Maintainers <dbus>
Severity:	enhancement
Priority:	medium	CC:	bugzilla
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	doc: Install introspection and busconfig DTDs doc: Install introspection and busconfig DTDs

Description Philip Withnall 2015-02-06 15:38:02 UTC

I’m wondering if it would be a good idea to install introspect.dtd and busconfig.dtd on the system, although probably only to be included in the dbus-devel package.

Installing them would mean that programs using D-Bus could validate their interface definitions and bus configurations against the schemas at compile time, without needing an internet connection to grab them from standards.freedesktop.org.

I guess they should be installed to $(datadir)/xml/dbus-1/, since that seems to be the convention for schemas.

Or is this a terrible idea?

Comment 1 Philip Withnall 2016-10-02 17:40:05 UTC

Created attachment 126956 [details] [review]
doc: Install introspection and busconfig DTDs

Install them to $(datadir)/xml/dbus-1, which seems to be the standard location for installed DTDs. This means that developers can use them to validate their introspection XML, and sysadmins can use them to validate their bus configuration files.

Comment 2 Simon McVittie 2016-10-03 10:26:29 UTC

Comment on attachment 126956 [details] [review]
doc: Install introspection and busconfig DTDs

Review of attachment 126956 [details] [review]:
-----------------------------------------------------------------

Sure, why not.

::: doc/Makefile.am
@@ +24,5 @@
>  	busconfig.dtd \
>  	introspect.dtd
>  
> +dtddir = $(datadir)/xml/dbus-1
> +dist_dtd_DATA = $(DTDS)

I'd slightly prefer just renaming DTDS to dist_dtd_DATA throughout.

Comment 3 Philip Withnall 2016-10-04 14:58:05 UTC

Created attachment 126994 [details] [review]
doc: Install introspection and busconfig DTDs

Install them to $(datadir)/xml/dbus-1, which seems to be the standard location for installed DTDs. This means that developers can use them to validate their introspection XML, and sysadmins can use them to validate their bus configuration files.

---

Changed to use $(dist_dtd_DATA) instead of $(DTDS) throughout.

Comment 4 Simon McVittie 2016-10-05 09:09:34 UTC

Fixed in git for 1.11.6, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.