I’m wondering if it would be a good idea to install introspect.dtd and busconfig.dtd on the system, although probably only to be included in the dbus-devel package. Installing them would mean that programs using D-Bus could validate their interface definitions and bus configurations against the schemas at compile time, without needing an internet connection to grab them from standards.freedesktop.org. I guess they should be installed to $(datadir)/xml/dbus-1/, since that seems to be the convention for schemas. Or is this a terrible idea?
Created attachment 126956 [details] [review] doc: Install introspection and busconfig DTDs Install them to $(datadir)/xml/dbus-1, which seems to be the standard location for installed DTDs. This means that developers can use them to validate their introspection XML, and sysadmins can use them to validate their bus configuration files.
Comment on attachment 126956 [details] [review] doc: Install introspection and busconfig DTDs Review of attachment 126956 [details] [review]: ----------------------------------------------------------------- Sure, why not. ::: doc/Makefile.am @@ +24,5 @@ > busconfig.dtd \ > introspect.dtd > > +dtddir = $(datadir)/xml/dbus-1 > +dist_dtd_DATA = $(DTDS) I'd slightly prefer just renaming DTDS to dist_dtd_DATA throughout.
Created attachment 126994 [details] [review] doc: Install introspection and busconfig DTDs Install them to $(datadir)/xml/dbus-1, which seems to be the standard location for installed DTDs. This means that developers can use them to validate their introspection XML, and sysadmins can use them to validate their bus configuration files. --- Changed to use $(dist_dtd_DATA) instead of $(DTDS) throughout.
Fixed in git for 1.11.6, thanks.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.