| Summary: | [BXT-P/SKL desktop/GLK] HDMI "testdisplay -y" shows wrong picture on every interlaced scanning resolution | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | liulei <lei.a.liu> | ||||||||||||||
| Component: | DRM/Intel | Assignee: | Mahesh Kumar <mahesh1.kumar> | ||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||||||
| Severity: | major | ||||||||||||||||
| Priority: | high | CC: | christophe.prigent, intel-gfx-bugs, james.ausmus, mahesh1.kumar | ||||||||||||||
| Version: | unspecified | ||||||||||||||||
| Hardware: | Other | ||||||||||||||||
| OS: | Linux (All) | ||||||||||||||||
| Whiteboard: | ReadyForDev | ||||||||||||||||
| i915 platform: | BXT, SKL | i915 features: | display/HDMI | ||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 115448 [details]
picture of wrong screen
Non-work resolution: 1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74250 1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74176 1920x1080i 50 1920 2448 2492 2640 1080 1084 1094 1125 0x15 0x40 74250 720x576i 50 720 732 795 864 576 580 586 625 0x101a 0x40 13500 720x480i 60 720 739 801 858 480 488 494 525 0x101a 0x40 13513 720x480i 60 720 739 801 858 480 488 494 525 0x101a 0x40 13500 Bug scrub: Reassigned to submitter Lei, do you still reproduce it? The problem persist on BDW with the following configuration with a different behavior: --- Software information --- ++ Kernel version : 4.4.4-040404-generic ++ Linux distribution : Ubuntu 15.10 ++ Architecture : 64-bit ++ xf86-video-intel version : 2.99.917 ++ Xorg-Xserver version : 1.17.2 ++ DRM version : 2.4.64 ++ VAAPI version : Intel i965 driver for Intel(R) Broadwell - 1.6.0 ++ Cairo version : 1.14.2 ++ Intel GPU Tools version : Tag [intel-gpu-tools-1.14-74-g431f6c4] / Commit [431f6c4] ++ Kernel driver in use : i915 ++ Bios revision : 5.6 --- Hardware information --- ++ Platform : ++ Motherboard model : ++ Motherboard type : NUC5i7RYB Desktop ++ Motherboard manufacturer : ++ CPU family : Core i7 ++ CPU information : Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz ++ GPU Card : Intel Corporation Broadwell-U Integrated Graphics (rev 09) (prog-if 00 [VGA controller]) ++ Memory ram : 8 GB ++ Maximum memory ram allowed : 16 GB ++ Display resolution : ++ CPU's number : 4 ++ Hard drive capacity : 120 GB Output: ./testdisplay -y (testdisplay:1576) igt-gt-CRITICAL: Test assertion failure function igt_get_stop_rings, file igt_gt.c:415: (testdisplay:1576) igt-gt-CRITICAL: Failed assertion: fd >= 0 (testdisplay:1576) igt-gt-CRITICAL: Last errno: 13, Permission denied Stack trace: #0 [__igt_fail_assert+0x101] #1 [igt_get_stop_rings+0xb9] #2 [check_stop_rings+0x6] #3 [gem_quiescent_gpu+0x3c] #4 [drm_open_driver+0x67] #5 [main+0x35e] #6 [__libc_start_main+0xf0] #7 [_start+0x29] #8 [<unknown>+0x29] Test (null) failed. **** DEBUG **** (testdisplay:1576) igt-core-DEBUG: Test requirement passed: !igt_run_in_simulation() (testdisplay:1576) drmtest-DEBUG: Test requirement passed: fd >= 0 (testdisplay:1576) igt-gt-CRITICAL: Test assertion failure function igt_get_stop_rings, file igt_gt.c:415: (testdisplay:1576) igt-gt-CRITICAL: Failed assertion: fd >= 0 (testdisplay:1576) igt-gt-CRITICAL: Last errno: 13, Permission denied **** END **** FAIL (-1.000s) This issue is also seen on BXT-P with the following configuration: Hardware configuration ======================= Platform BXT - P (APL) Motherboard model Apollo Lake Motherboard type NOTEBOOK Hand Held Motherboard manufacturer Intel Corp. CPU family Other CPU information 06/5c GPU Card Intel Corporation Device 5a84 (rev 03) (prog-if 00 [VGA controller]) Memory ram 8 GB Software configuration ======================= --> Component : drm url : http://cgit.freedesktop.org/mesa/drm tag : libdrm-2.4.67-11-gea78c17 commit : ea78c17 author : Emil Velikov <emil.l.velikov@gmail.com> age : 20 hours ago --> Component : mesa url : http://cgit.freedesktop.org/mesa/mesa tag : mesa-11.1.2 commit : 7bcd827 author : Emil Velikov <emil.velikov@collabora.com> age : 7 weeks ago --> Component : xf86-video-intel url : http://cgit.freedesktop.org/xorg/driver/xf86-video-intel tag : 2.99.917-590-g094924f commit : 094924f author : Chris Wilson <chris@chris-wilson.co.uk> age : 4 days ago --> Component : libva url : http://cgit.freedesktop.org/libva/ tag : libva-1.7.0-1-g2339d10 commit : 2339d10 author : Xiang Haihao <haihao.xiang@intel.com> age : 13 days ago --> Component : vaapi (intel-driver) url : http://cgit.freedesktop.org/vaapi/intel-driver tag : 1.7.0-5-g759e44d commit : 759e44d author : peng.chen <peng.c.chen@intel.com> age : 13 days ago --> Component : cairo url : http://cgit.freedesktop.org/cairo tag : 1.15.2 commit : db8a7f1 author : Bryce Harrington <bryce@osg.samsung.com> age : 4 months ago --> Component : xserver url : http://cgit.freedesktop.org/xorg/xserver tag : xorg-server-1.18.0-254-g44e1c97 commit : 44e1c97 author : Olivier Fourdan <ofourdan@redhat.com> age : 8 days ago --> Component : intel-gpu-tools url : http://cgit.freedesktop.org/xorg/app/intel-gpu-tools tag : intel-gpu-tools-1.14-129-g41a26b5 commit : 41a26b5 author : Chris Wilson <chris@chris-wilson.co.uk> age : 26 hours ago kernel configuration ===================== Branch : drm-intel-nightly commit f5d413cccefa1f93d64c34f357151d42add63a84 Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Date: Thu Mar 24 14:35:16 2016 +0000 drm-intel-nightly: 2016y-03m-24d-14h-34m-29s UTC integration manifest Kernel version : 4.5.0 Architecture : source amd64 all Attachments ======================== You can see dmesg-BXT-P.log in the attachment Created attachment 122640 [details]
dmesg-BXT-P
Increasing priority due to current platform experience impact Issue is still present on SKL with the following config: === Software information ===, Kernel version,4.6.1-mainline-ww24-version-4.6.1, Linux distribution,Ubuntu 16.04 LTS, Architecture,64-bit, Mesa version,11.2.2 (git-3a9f628, xf86-video-intel version,2.99.917, Xorg-Xserver version,1.18.3, DRM version,2.4.68, libva version,, Cairo version,1.15.2, Intel GPU Tools version,, Kernel driver in use,\e[1m\e[1;32mi915\e[0m, Hardware acceleration,\e[1;32mEnabled\e[0m, Bios revision,1.0, KSC revision,\e[1m\e[1;31mNot found\e[0m <-- \e[1;33mmaybe the DUT doesn't has this firmware\e[0m, === Hardware information ===, Platform,SKL, Motherboard model,Inspiron 15-7568, Motherboard type,02HK88 Laptop, Motherboard manufacturer,Dell Inc., CPU family,Core i7, CPU information,Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz, GPU Card,Intel Corporation Sky Lake Integrated Graphics (rev 07) (prog-if 00 [VGA controller]), Adding kernel and some more info for my previous comment: Software information ============================================ Kernel version : 4.6.1-mainline-ww24-version-4.6.1 Linux distribution : Ubuntu 16.04 LTS Architecture : 64-bit Mesa version : 11.2.2 (git-3a9f628 xf86-video-intel version : 2.99.917 Xorg-Xserver version : 1.18.3 DRM version : 2.4.68 VAAPI version : Intel i965 driver for Intel(R) Skylake - 1.7.1.pre1 (1.7.1.pre1) Cairo version : 1.15.2 Intel GPU Tools version : Tag [intel-gpu-tools-1.15] / Commit [3ce58b6] Kernel driver in use : i915 Firmwares information ============================================ DMC fw loaded : yes DMC version : 1.26 (In reply to Luis Botello from comment #9) > Kernel version : 4.6.1-mainline-ww24-version-4.6.1 Huh? What is that? How about drm-intel-nightly? Issue still present with the followinf config: Software information ============================================ Kernel version : 4.7.0-rc5-nightly+ Linux distribution : Ubuntu 16.04 LTS Architecture : 64-bit Mesa version : 11.2.2 (git-3a9f628 xf86-video-intel version : 2.99.917 Xorg-Xserver version : 1.18.99.1 DRM version : 2.4.68 VAAPI version : Intel i965 driver for Intel(R) Broxton - 1.7.2.pre1 (1.7.0-53-gbcde10d) Cairo version : 1.15.2 Intel GPU Tools version : Tag [intel-gpu-tools-1.15-87-g376b813] / Commit [376b813] Kernel driver in use : i915 Hardware acceleration : Enabled Bios revision : 144.10 KSC revision : 1.15 Hardware information ============================================ Platform : BXT-P Motherboard model : Broxton P GPU Card : Intel Corporation Device 5a84 (rev 0a) (prog-if 00 [VGA controller]) Memory ram : 8 GB CPU's number : 4 Firmwares information ============================================ DMC version : 1.7 GUC version found : 8.7 this issue still present with this kernel. 4.10.0-rc8-drm-tip-ww8-commit-58294e4+ platform: KBL-U Issue still present, removing NeedInfo status since info has been provided. Also changing assignee to default Adding tag into "Whiteboard" field - ReadyForDev The bug still active *Status is correct *Platform is included *Feature is included *Priority and Severity correctly set *Logs included Created attachment 131708 [details] [review] Proposed Patch By-default IF-ID mode is used in interlace mode. SKL+ doesn't support Y-tile with IF-ID mode, that is the reason, There are underrun & distorted output. Attached patch enables PF-ID mode of scaler for SKL. There is limited testing done for this patch. Please check with Attached patch & let me know if it solves the issue. *PF-ID Interlace mode, (not the PF-ID mode of scaler) This PF-ID mode require one scaler to be attached in pipe-scalar mode. Reporter, there is potential fix as patch. Does this resolve issue for you? Unable to compile kernel after applying proposed patch, I got the following compilation error:
drivers/gpu/drm/i915/intel_display.c: In function ‘skl_update_scaler_crtc_pf_id_output’:
drivers/gpu/drm/i915/intel_display.c:4706:9: error: too many arguments to function ‘skl_update_scaler’
return skl_update_scaler(state, !state->base.active,
^
drivers/gpu/drm/i915/intel_display.c:4612:1: note: declared here
skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,
^
scripts/Makefile.build:302: recipe for target 'drivers/gpu/drm/i915/intel_display.o' failed
make[6]: *** [drivers/gpu/drm/i915/intel_display.o] Error 1
scripts/Makefile.build:561: recipe for target 'drivers/gpu/drm/i915' failed
make[5]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:561: recipe for target 'drivers/gpu/drm' failed
make[4]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:561: recipe for target 'drivers/gpu' failed
make[3]: *** [drivers/gpu] Error 2
Makefile:1016: recipe for target 'drivers' failed
make[2]: *** [drivers] Error 2
scripts/package/Makefile:91: recipe for target 'deb-pkg' failed
make[1]: *** [deb-pkg] Error 2
Makefile:1345: recipe for target 'deb-pkg' failed
make: *** [deb-pkg] Error 2
Created attachment 131912 [details] [review] updated proposed patch There were framework changes, It required rebasing of patch. rebased patch is available in patchwork link below: https://patchwork.freedesktop.org/series/25397/ Updating modified patch here as well. -Mahesh Hi Makesh: I tried to apply the patch provided, unfortunately I was not able to perform that operation properly, because I got a failure due to it some hunks are not longer applicable. $patch -p1 < ../drm-i915-skl-enable-PF_ID-interlace-mode-in-SKL.mbox patching file drivers/gpu/drm/i915/intel_atomic.c patching file drivers/gpu/drm/i915/intel_display.c Hunk #1 succeeded at 4690 with fuzz 2 (offset 64 lines). Hunk #2 FAILED at 4640. Hunk #3 succeeded at 4767 with fuzz 2 (offset 71 lines). Hunk #4 succeeded at 6148 (offset -125 lines). Hunk #5 succeeded at 7954 (offset -115 lines). 1 out of 5 hunks FAILED -- saving rejects to file drivers/gpu/drm/i915/intel_display.c.rej patching file drivers/gpu/drm/i915/intel_drv.h Hunk #1 succeeded at 484 (offset 1 line). Hunk #2 succeeded at 1190 (offset -17 lines). patching file drivers/gpu/drm/i915/intel_panel.c Hunk #1 FAILED at 108. 1 out of 1 hunk FAILED -- saving rejects to file drivers/gpu/drm/i915/intel_panel.c.rej patching file drivers/gpu/drm/i915/intel_pm.c Hunk #1 FAILED at 3873. Hunk #2 FAILED at 3891. Hunk #3 succeeded at 4335 (offset -83 lines). 2 out of 3 hunks FAILED -- saving rejects to file drivers/gpu/drm/i915/intel_pm.c.rej This is my output. Hi Antonia, Interlace modes with Y-tiling is not supported in Gen9+ (SKL & GLK). Two patches to implement this limitation are already merged. Now any calls which requests Interlace mode with Y-tiling gets rejected by kernel instead of corrupted output. -Mahesh (In reply to Mahesh Kumar from comment #21) > Hi Antonia, > > Interlace modes with Y-tiling is not supported in Gen9+ (SKL & GLK). > Two patches to implement this limitation are already merged. > > Now any calls which requests Interlace mode with Y-tiling gets rejected by > kernel instead of corrupted output. > > -Mahesh Hello Mahesh, is this comment really for this bug? If so, you're suggesting to test again with latest commit?? (In reply to Elizabeth from comment #22) > (In reply to Mahesh Kumar from comment #21) > > Hi Antonia, > > > > Interlace modes with Y-tiling is not supported in Gen9+ (SKL & GLK). > > Two patches to implement this limitation are already merged. > > > > Now any calls which requests Interlace mode with Y-tiling gets rejected by > > kernel instead of corrupted output. > > > > -Mahesh > Hello Mahesh, is this comment really for this bug? If so, you're suggesting > to test again with latest commit?? sorry for late reply, mail escaped from my inbox :). yes it's for same bug, Let me correct little-bit here, Interlace more (IF-ID) with Y-tiling is not supported in Gen9+, below is the link for patches. https://patchwork.freedesktop.org/series/26546/ yes Please check with latest commit. Now commit will fail instead of corrupted image, because we use IF-ID for Interlace mode. -Mahesh Created attachment 136020 [details] dmesg_log_testdisplay-y (In reply to Mahesh Kumar from comment #23) > (In reply to Elizabeth from comment #22) > > (In reply to Mahesh Kumar from comment #21) > > > Hi Antonia, > > > > > > Interlace modes with Y-tiling is not supported in Gen9+ (SKL & GLK). > > > Two patches to implement this limitation are already merged. > > > > > > Now any calls which requests Interlace mode with Y-tiling gets rejected by > > > kernel instead of corrupted output. > > > > > > -Mahesh > > Hello Mahesh, is this comment really for this bug? If so, you're suggesting > > to test again with latest commit?? > > sorry for late reply, mail escaped from my inbox :). > yes it's for same bug, Let me correct little-bit here, Interlace more > (IF-ID) with Y-tiling is not supported in Gen9+, below is the link for > patches. > https://patchwork.freedesktop.org/series/26546/ > yes Please check with latest commit. Now commit will fail instead of > corrupted image, because we use IF-ID for Interlace mode. > > -Mahesh Hello Manesh, As you state, when run interlaced modes I got a warn message in the test output instead a corrupted image. So as this is to be expected this can be considered fixed for gen9+, is that right? Thanks. This is the output of the test, I'll test with the others platforms listed in the bug as soon as I get some time for it: $ : sudo -E ./intel-graphics/intel-gpu-tools/tests/testdisplay -y > testdisplay_output (testdisplay:1763) WARNING: failed to set mode (1920x1080@60Hz): Invalid argument (testdisplay:1763) WARNING: failed to set mode (1920x1080@60Hz): Invalid argument (testdisplay:1763) WARNING: failed to set mode (1920x1080@50Hz): Invalid argument (05:10 PM) [gfx@gfx-desktop] [~]$ : sudo -E ./intel-graphics/intel-gpu-tools/tests/testdisplay -y CRTC(37):[0] 3840x2160 30 3840 4016 4104 4400 2160 2168 2178 2250 0x9 0x48 297000 CRTC(37):[1] 3840x2160 30 3840 4016 4104 4400 2160 2168 2178 2250 0x5 0x40 297000 CRTC(37):[2] 3840x2160 30 3840 4016 4104 4400 2160 2168 2178 2250 0x5 0x40 296703 CRTC(37):[3] 3840x2160 25 3840 4896 4984 5280 2160 2168 2178 2250 0x5 0x40 297000 CRTC(37):[4] 3840x2160 24 3840 5116 5204 5500 2160 2168 2178 2250 0x5 0x40 297000 CRTC(37):[5] 3840x2160 24 3840 5116 5204 5500 2160 2168 2178 2250 0x5 0x40 296703 CRTC(37):[6] 2560x1600 60 2560 2608 2640 2720 1600 1603 1609 1646 0x9 0x40 268500 CRTC(37):[7] 2560x1440 60 2560 2608 2640 2720 1440 1443 1448 1481 0x5 0x40 241500 CRTC(37):[8] 1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x40 148500 CRTC(37):[9] 1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x40 148352 CRTC(37):[10] 1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74250 (testdisplay:1845) WARNING: failed to set mode (1920x1080@60Hz): Invalid argument CRTC(37):[11] 1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74176 (testdisplay:1845) WARNING: failed to set mode (1920x1080@60Hz): Invalid argument CRTC(37):[12] 1920x1080 50 1920 2448 2492 2640 1080 1084 1089 1125 0x5 0x40 148500 CRTC(37):[13] 1920x1080i 50 1920 2448 2492 2640 1080 1084 1094 1125 0x15 0x40 74250 (testdisplay:1845) WARNING: failed to set mode (1920x1080@50Hz): Invalid argument CRTC(37):[14] 1920x1080 30 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x40 74250 CRTC(37):[15] 1920x1080 30 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x40 74176 CRTC(37):[16] 1920x1080 24 1920 2558 2602 2750 1080 1084 1089 1125 0x5 0x40 74250 CRTC(37):[17] 1920x1080 24 1920 2558 2602 2750 1080 1084 1089 1125 0x5 0x40 74176 CRTC(37):[18] 1680x1050 60 1680 1728 1760 1840 1050 1053 1059 1080 0x9 0x40 119000 CRTC(37):[19] 1280x1024 75 1280 1296 1440 1688 1024 1025 1028 1066 0x5 0x40 135000 CRTC(37):[20] 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x40 108000 CRTC(37):[21] 1440x900 60 1440 1488 1520 1600 900 903 909 926 0x9 0x40 88750 CRTC(37):[22] 1280x960 60 1280 1376 1488 1800 960 961 964 1000 0x5 0x40 108000 CRTC(37):[23] 1152x864 75 1152 1216 1344 1600 864 865 868 900 0x5 0x40 108000 CRTC(37):[24] 1280x720 60 1280 1390 1430 1650 720 725 730 750 0x5 0x40 74250 CRTC(37):[25] 1280x720 60 1280 1390 1430 1650 720 725 730 750 0x5 0x40 74176 CRTC(37):[26] 1280x720 50 1280 1720 1760 1980 720 725 730 750 0x5 0x40 74250 CRTC(37):[27] 1440x576 50 1440 1464 1592 1728 576 581 586 625 0xa 0x40 54000 CRTC(37):[28] 1024x768 75 1024 1040 1136 1312 768 769 772 800 0x5 0x40 78750 CRTC(37):[29] 1024x768 70 1024 1048 1184 1328 768 771 777 806 0xa 0x40 75000 CRTC(37):[30] 1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000 CRTC(37):[31] 1440x480 60 1440 1472 1596 1716 480 489 495 525 0xa 0x40 54054 CRTC(37):[32] 1440x480 60 1440 1472 1596 1716 480 489 495 525 0xa 0x40 54000 CRTC(37):[33] 832x624 75 832 864 928 1152 624 625 628 667 0xa 0x40 57284 CRTC(37):[34] 800x600 75 800 816 896 1056 600 601 604 625 0x5 0x40 49500 CRTC(37):[35] 800x600 72 800 856 976 1040 600 637 643 666 0x5 0x40 50000 CRTC(37):[36] 800x600 60 800 840 968 1056 600 601 605 628 0x5 0x40 40000 CRTC(37):[37] 800x600 56 800 824 896 1024 600 601 603 625 0x5 0x40 36000 CRTC(37):[38] 720x576 50 720 732 796 864 576 581 586 625 0xa 0x40 27000 CRTC(37):[39] 720x480 60 720 736 798 858 480 489 495 525 0xa 0x40 27027 CRTC(37):[40] 720x480 60 720 736 798 858 480 489 495 525 0xa 0x40 27000 CRTC(37):[41] 640x480 75 640 656 720 840 480 481 484 500 0xa 0x40 31500 CRTC(37):[42] 640x480 73 640 664 704 832 480 489 492 520 0xa 0x40 31500 CRTC(37):[43] 640x480 67 640 704 768 864 480 483 486 525 0xa 0x40 30240 CRTC(37):[44] 640x480 60 640 656 752 800 480 490 492 525 0xa 0x40 25200 CRTC(37):[45] 640x480 60 640 656 752 800 480 490 492 525 0xa 0x40 25175 CRTC(37):[46] 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 28320 SUCCESS (-1.000s) This bug is not valid for BDW, please open a new bug for BDW. Closing, resolved for Gen9+. Thank you. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 115447 [details] dmesg ==System Environment== -------------------------- Regression: No. This is first time test on this machine. Non-working platforms: SKL ==kernel== -------------------------- -nightly: 9a4da5ec419897b78c1d4a3949c0c049db5402c5 (fails) drm-intel-nightly: 2015y-04m-28d-14h-41m-15s UTC integration manifest -queued: de4de566f84b87f4d5f8265b11932088adb19896 (fails) drm/i915: Update DRIVER_DATE to 20150423 -fixes: a04f90a33fab74789b91fc9739999012f11022d1 (fails) drm/i915/chv: Implement WaDisableShadowRegForCpd ==Bug detailed description== ----------------------------- HDMI "testdisplay -y" shows wrong picture on every interlaced scanning resolution ==Reproduce steps== ---------------------------- ./testdisplay -y