Bug 90994

Summary: [KBL BDW regression] pm_rpm subtests fail and give WARNs
Product: DRI Reporter: Paulo Zanoni <przanoni>
Component: DRM/IntelAssignee: Maarten Lankhorst <bugs>
Status: CLOSED DUPLICATE QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: high CC: intel-gfx-bugs, przanoni
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: BDW, HSW, KBL, SKL i915 features: power/runtime PM

Description Paulo Zanoni 2015-06-16 18:30:52 UTC
Steps to reproduce:
- Boot BDW on -nightly
(I currently have eDP + HDMI + DP attached when I boot, but that shouldn't matter)
- sudo ./pm_rpm --quick
- see all the failures
- check for the dmesg WARNs

Expected results:
- All tests pass
- Not a single WARN or ERROR on dmesg

Both the WARNs and test failures are regressions. I'm 100% sure that a few months ago we were passing every test without any WARNs. So these current problems are actual regressions.

As far as I remember, thee "dpms" subtest failures are _very_ recent, so it should be fairly quick to bisect them.

Why didn't we catch these regressions with PRTS?
Why didn't we catch these regressions with nightly testing?

Related discussion:
http://lists.freedesktop.org/archives/intel-gfx/2015-June/068830.html

Logs:
http://people.freedesktop.org/~pzanoni/pm_rpm.txt
http://people.freedesktop.org/~pzanoni/dmesg.txt
Comment 1 lu hua 2015-06-17 08:17:31 UTC
I also see following case fail:
igt@pm_rpm@cursor-dpms
igt@pm_rpm@dpms-lpsp
igt@pm_rpm@dpms-mode-unset-lpsp
igt@pm_rpm@dpms-non-lpsp
igt@pm_rpm@drm-resources-equal
igt@pm_rpm@fences-dpms
igt@pm_rpm@gem-evict-pwrite
igt@pm_rpm@legacy-planes-dpms
igt@pm_rpm@universal-planes-dpms

Bisect shows: 7f072451f2d3d53e4f6939440e15ab36afed2051 is the first bad commit.
commit 7f072451f2d3d53e4f6939440e15ab36afed2051
Author:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
AuthorDate: Mon Jun 1 12:50:04 2015 +0200
Commit:     Jani Nikula <jani.nikula@intel.com>
CommitDate: Thu Jun 4 11:44:37 2015 +0300

    drm/i915: Implement intel_crtc_control using atomic state, v4

    Assume the callers lock everything with drm_modeset_lock_all.

    This change had to be done after converting suspend/resume to
    use atomic_state so the atomic state is preserved, otherwise
    all transitional state is erased.

    Now all callers of .crtc_enable and .crtc_disable go through
    atomic modeset! :-D

    Changes since v1:
    - Only check for crtc_state->active in valleyview_modeset_global_pipes.
    - Only check for crtc_state->active in modeset_update_crtc_power_domains.
    Changes since v2:
    - Rework on top of the changed patch order.
    Changes since v3:
    - Rename intel_crtc_toggle in description to *_control
    - Change return value to int.
    - Do not add plane state, should be done implicitly already.

    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Comment 2 Maarten Lankhorst 2015-07-16 08:11:28 UTC
Can you recheck? My broadwell NUC passes the tests now.
Comment 3 Jesse Barnes 2015-08-03 21:24:23 UTC
Need QA to re-test.
Comment 4 Paulo Zanoni 2015-08-04 20:50:23 UTC
I recently tested this and the dpms tests are passing now. Yet we still have other WARNs and FAILures in other subtests - and these are all regressions.
Comment 5 Maarten Lankhorst 2015-08-10 09:55:55 UTC
What failures exactly?
Comment 6 Elio 2015-10-01 16:25:22 UTC
The following test cases are failing :
pm_rpm@modeset-pc8-residency-stress
pm_rpm@pc8-residency
pm_rpm@universal-planes-dpms

Returncode	99
Time	0:00:01.830615
Stdout	
IGT-Version: 1.12-g1f9e055 (x86_64) (Linux: 4.3.0-rc2-drm-intel-nightly+ x86_64)
Runtime PM support: 1
PC8 residency support: 1
Stack trace:
  #0 [__igt_fail_assert+0xf1]
  #1 [igt_wait_for_pm_status+0x0]
  #2 [igt_wait_for_pm_status+0x56]
  #3 [planes_subtest+0x335]
  #4 [main+0xca0]
  #5 [__libc_start_main+0xf5]
  #6 [_start+0x29]
  #7 [<unknown>+0x29]
Subtest universal-planes-dpms: FAIL (0.314s)
Stderr	
Test assertion failure function igt_get_runtime_pm_status, file igt_aux.c:603:
Failed assertion: false
Last errno: 2, No such file or directory
Unknown status unsupported

Subtest universal-planes-dpms failed.
**** DEBUG ****
Test requirement passed: rc == 0
Test assertion failure function igt_get_runtime_pm_status, file igt_aux.c:603:
Failed assertion: false
Last errno: 2, No such file or directory
Unknown status unsupported

****  END  ****


Configuration:

Kernel 4.3.0-rc8-drm-intel-testing-2015-08-28
Mesa: mesa-10.6.7 from http://cgit.freedesktop.org/mesa/mesa/
Xf86_video_intel: 2.99.917 from
http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/
Libdrm: libdrm-2.4.64 from http://cgit.freedesktop.org/mesa/drm/
Cairo: 1.14.2 from http://cgit.freedesktop.org/cairo
libva: libva-1.6.0 from http://cgit.freedesktop.org/libva/
intel-driver: 1.6.1. from http://cgit.freedesktop.org/vaapi/intel-driver
xorg: 1.17.99 installed with script git_xorg.sh
Xserver: xorg-server-1.17.2 from http://cgit.freedesktop.org/xorg/xserver
Intel-gpu-tools: 1.12 from http://cgit.freedesktop.org/xorg/app/intel-gpu
Comment 7 Humberto Israel Perez Rodriguez 2015-10-15 18:11:26 UTC
With HSW with the latest configuration only fails the follwing sub-tests tests:

Sub-tests :
---------------------------------------------
<%modeset-pc8-residency-stress%>
<%pc8-residency%>
<%gem-execbuf-stress-pc8%>

Configuration :
---------------------------------------------
kernel: 4.3.0-rc4-drm-intel-testing-2015-10-10
xorg-server-1.17.2
libdrm-2.4.65
xf86-video-intel-2.99.917
mesa-11.0.2
libva-1.6.1
intel-driver-1.6.1
cairo-1.14.2
IGT Version : 1.12-g1f9e055
Comment 8 Humberto Israel Perez Rodriguez 2015-12-11 04:45:50 UTC
The following test keeps fail with latest set up on SKL-Y :

pm_rpm@drm-resources-equal


 --- Hardware information ---
Motherboard model             : Skylake Client platform
Motherboard type              : Skylake Y LPDDR3 RVP3 Laptop
Motherboard manufacturer      : Intel Corporation
CPU information               : Intel(R) Core(TM) m5-6Y57 CPU @ 1.10GHz
GPU Card                      : Intel Corporation Sky Lake Integrated Graphics (rev 07) (prog-if 00 [VGA controller])
KSC                           : 1.15

Linux distribution: Ubuntu 15.10 LTS 64 bits
Kernel: 4.3 mainline from https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/?id=refs/tags/v4.3
Bios SKL: SKLSE2R1.R00.B104.B01.1511110114)
xorg-server-1.18.0 from http://cgit.freedesktop.org/xorg/xserver
libdrm-2.4.65 from http://cgit.freedesktop.org/mesa/drm/
xf86-video-intel 2.99.917 from http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/
mesa-11.0.4 from http://cgit.freedesktop.org/mesa/mesa/
libva-1.6.2.pre1 from http://cgit.freedesktop.org/libva/
vaapi-intel-driver 1.6.2.pre1 from http://cgit.freedesktop.org/vaapi/intel-driver
cairo 1.14.4 from http://cgit.freedesktop.org/cairo
Rendercheck 1.5 from http://cgit.freedesktop.org/xorg/app/rendercheck
SKL-Y :  DMC 1.23 and GUC 4.3 firmware from https://01.org/linuxgraphics/intel-linux-graphics-firmwares
IGT 1.13: http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/commit/?id=2db78a4995a8ee298ae0cd68879baf80407a0e5e
Comment 9 Rami 2016-03-25 16:48:05 UTC
This subteset still fail on bdw with last setup:
gem-execbuf-stress-pc8
pc8-residency-stress
pc8-residency

Setup:
======
Intel(R) Core(TM) i5-5300U CPU @ 2.30GHz
BIOS Version: BDW-E2R1.86C.0095.R09.1410300006

Kernel drm-intel-nightly: 2016y-03m-24d-14h-34m-29s UTC integration manifest
commit f5d413cccefa1f93d64c34f357151d42add63a84
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date:   Thu Mar 24 14:35:16 2016 +0000
 
drm: libdrm-2.4.67-5 ea07de9 from git://anongit.freedesktop.org/mesa/drm
mesa: tag mesa-11.1.2 7bcd827 from git://anongit.freedesktop.org/mesa/mesa
cairo: tag 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo
waffle: master bb29b2a from git://github.com/waffle-gl/waffle
xorg-server-macros: tag: util-macros-1.19.0-2 d7acec2 from git://git.freedesktop.org/git/xorg/util/macros
xserver: tag: xorg-server-1.18.1 23e60f9 from git://git.freedesktop.org/git/xorg/xserver
xf86-video-intel: tag 2.99.917-560 d167280 from git://anongit.freedesktop.org/xorg/driver/xf86-video-intel
libva: tag libva-1.7.0.pre1 35f1447 from git://git.freedesktop.org/git/vaapi/libva
vaapi-intel-driver: tag 1.7.0.pre1 ab8e4e3 from git://anongit.freedesktop.org/vaapi/intel-driver
IGT 1.14 364d378 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git
Comment 10 Jairo Miramontes 2016-04-27 00:30:41 UTC
The following subtest is failing on KBL on the below configuration
==test== 
pm_rpm@cursor-dpms


Software information
====================

Kernel version                      : 4.6.0-rc4-drm-intel-nightly-ww17-commit-1e81bac+
Linux distribution                  : Ubuntu 15.10
Architecture                        : 64-bit
Bios revision                       : 5.5
KSC revision                        : 1.20


Hardware information
=====================

Platform                            : KBL (RVP7)
Motherboard model                   : Kabylake Client platform
Motherboard type                    : Skylake U DDR3L RVP7 Laptop
Motherboard manufacturer            : Intel Corporation
CPU family                          : Other
CPU information                     : Genuine Intel(R) CPU 0000 @ 2.60GHz
GPU Card                            : Intel Corporation Device 5916 (prog-if 00 [VGA controller])
Memory ram                          : 4 GB

Kernel
======================
commit 1e81bacf1f7fdbdf83f46b55389713fa13cb1256
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sun Apr 24 11:36:51 2016 +0100

    drm-intel-nightly: 2016y-04m-24d-10h-36m-11s UTC integration manifest


Kernel version : 4.6.0-rc4
Architecture : source amd64 all
Homepage : http://www.kernel.org/


Graphic stack
=====================
--> Component : drm 
                 url : http://cgit.freedesktop.org/mesa/drm 
                 tag : libdrm-2.4.67-26-g739b888 
                 commit : 739b888 
                 author : Nicolas Dechesne <nicolas.dechesne@linaro.org> 
                 age : 2 weeks ago 
 --> Component : mesa 
                 url : http://cgit.freedesktop.org/mesa/mesa 
                 tag : mesa-11.1.2 
                 commit : 7bcd827 
                 author : Emil Velikov <emil.velikov@collabora.com> 
                 age : 3 months ago 
 --> Component : xf86-video-intel 
                 url : http://cgit.freedesktop.org/xorg/driver/xf86-video-intel 
                 tag : 2.99.917-640-gbca4e0e 
                 commit : bca4e0e 
                 author : Chris Wilson <chris@chris-wilson.co.uk> 
                 age : 2 days ago 
 --> Component : libva 
                 url : http://cgit.freedesktop.org/libva/ 
                 tag : libva-1.7.0-1-g2339d10 
                 commit : 2339d10 
                 author : Xiang Haihao <haihao.xiang@intel.com> 
                 age : 6 weeks ago 
 --> Component : vaapi (intel-driver) 
                 url : http://cgit.freedesktop.org/vaapi/intel-driver 
                 tag : 1.7.0-8-g2c1bec0 
                 commit : 2c1bec0 
                 author : peng.chen <peng.c.chen@intel.com> 
                 age : 3 weeks ago 
 --> Component : cairo 
                 url : http://cgit.freedesktop.org/cairo 
                 tag : 1.15.2 
                 commit : db8a7f1 
                 author : Bryce Harrington <bryce@osg.samsung.com> 
                 age : 5 months ago 
 --> Component : xserver 
                 url :  http://cgit.freedesktop.org/xorg/xserver 
                 tag : xorg-server-1.18.0-291-g16e4bce 
                 commit : 16e4bce 
                 author : Simon Thum <simon.thum@gmx.de> 
                 age : 2 weeks ago 
 --> Component : intel-gpu-tools 
                 url : http://cgit.freedesktop.org/xorg/app/intel-gpu-tools 
                 tag : intel-gpu-tools-1.14-212-g1e9a3ac 
                 commit : 1e9a3ac 
                 author : Chris Wilson <chris@chris-wilson.co.uk> 
                 age : 3 days ago
Comment 11 cprigent 2016-04-29 11:55:50 UTC

*** This bug has been marked as a duplicate of bug 93123 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.