Test assertion failure function pci_d3_state_subtest, file pm_rpm.c:1382: Failed assertion: device_in_pci_d3() Subtest basic-pci-d3-state failed. **** DEBUG **** Test requirement passed: has_runtime_pm Test assertion failure function pci_d3_state_subtest, file pm_rpm.c:1382: Failed assertion: device_in_pci_d3() **** END **** SNB supports runtime (and it did work on the other snb in CI before bug #93122 so should really work
Please attach the dmesg etc. so we can at least have a chance at looking at what type of machine it is. Borderline invalid with the amount of info here...
There is no dmesg, the test apparently falls over before anything interesting happens. What I forgotten to paste from CI is stdout: IGT-Version: 1.12-ge10ba6b (x86_64) (Linux: 4.4.0-rc2-gfxbench+ x86_64) Runtime PM support: 1 PC8 residency support: 0 Stack trace: #0 [__igt_fail_assert+0x101] #1 [main+0x247c] #2 [__libc_start_main+0xf0] #3 [_start+0x29] Subtest basic-pci-d3-state: FAIL (2.135s) Full details at http://benchsrv.fi.intel.com/archive/results/CI_IGT_test/CI_DRM_848/snb-x220t/html/snb-x220t@CI_DRM_848@1/igt@pm_rpm@basic-pci-d3-state.html There really isn't anything more there (and since it's CI fail I can't get at the machine myself).
I don't see how I can make progress on this without further info. I will try to get my hands on a SNB machine and start digging from there.
Created attachment 120452 [details] dmesg 4.3.0-gfxbench+ (November 2nd 2015)
Dropping to high.
I don't hit this on my snb i5-2500s, but looking at the pci code there are various delays in setting D3 that may interfere with the test, so https://patchwork.freedesktop.org/patch/76047/ waits for a couple of seconds before failing.
Pushed igt commit ec1ac2e2e952778c204374a6d186ec40951bc256 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Mar 7 14:01:18 2016 +0000 igt/pm_rpm: Wait for PCI D3 The transition to PCI device state D3 is not instantaneous and only started when runtime suspended. Allow the driver/hardware a little bit of time to complete the transition before declaring a test failure. References: https://bugs.freedesktop.org/show_bug.cgi?id=93123 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> So let's hope this is just one of the quirky PCI devices. Please test on the troublesome SNB.
(In reply to Chris Wilson from comment #7) > Pushed igt commit ec1ac2e2e952778c204374a6d186ec40951bc256 > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Mon Mar 7 14:01:18 2016 +0000 > > igt/pm_rpm: Wait for PCI D3 Seems like the problem still happens with this in CI run 1542: IGT-Version: 1.14-g3a7325e (x86_64) (Linux: 4.5.0-rc7-gfxbench+ x86_64) Runtime PM support: 1 PC8 residency support: 0 Stack trace: #0 [__igt_fail_assert+0x101] #1 [main+0xd6f] #2 [__libc_start_main+0xf0] #3 [_start+0x29] Subtest basic-pci-d3-state: FAIL (2.574s) (pm_rpm:5653) CRITICAL: Test assertion failure function pci_d3_state_subtest, file pm_rpm.c:1355: (pm_rpm:5653) CRITICAL: Failed assertion: igt_wait(device_in_pci_d3(), 2000, 100) Subtest basic-pci-d3-state failed. **** DEBUG **** (pm_rpm:5653) DEBUG: Test requirement passed: has_runtime_pm (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) DEBUG: device_in_pci_d3: PCI D3 state=0 (pm_rpm:5653) CRITICAL: Test assertion failure function pci_d3_state_subtest, file pm_rpm.c:1355: (pm_rpm:5653) CRITICAL: Failed assertion: igt_wait(device_in_pci_d3(), 2000, 100) **** END ****
Can you please apply diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 602eb4223510..916acdd18b15 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -594,8 +594,14 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state) if (dev->current_state == state) return 0; - if (!dev->pm_cap) + dev_info(&dev->dev, "changing power state, from %s [%d] to %s [%d]\n", + pci_power_name(dev->current_state) dev->current_state, + pci_power_name(state), state); + + if (!dev->pm_cap) { + dev_err(&dev->dev, "unable to change power levels (no pm_cap)\n"); return -EIO; + } if (state < PCI_D0 || state > PCI_D3hot) return -EINVAL; and let's confirm that we do get the PCI power change request.
Following subtest are failing in BDW with following configuration: @modeset-non-lpsp-stress-no-wait @pc8-residency @reset --- Software information --- ++ Kernel version : 4.4.4-040404-generic ++ Linux distribution : Ubuntu 15.10 ++ Architecture : 64-bit ++ xf86-video-intel version : 2.99.917 ++ Xorg-Xserver version : 1.17.2 ++ DRM version : 2.4.64 ++ VAAPI version : Intel i965 driver for Intel(R) Broadwell - 1.6.0 ++ Cairo version : 1.14.2 ++ Intel GPU Tools version : Tag [intel-gpu-tools-1.14-74-g431f6c4] / Commit [431f6c4] ++ Kernel driver in use : i915 ++ Bios revision : 5.6 --- Hardware information --- ++ Platform : ++ Motherboard model : ++ Motherboard type : NUC5i7RYB Desktop ++ Motherboard manufacturer : ++ CPU family : Core i7 ++ CPU information : Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz ++ GPU Card : Intel Corporation Broadwell-U Integrated Graphics (rev 09) (prog-if 00 [VGA controller]) ++ Memory ram : 8 GB ++ Maximum memory ram allowed : 16 GB ++ Display resolution : ++ CPU's number : 4 ++ Hard drive capacity : 120 GB Output: ./pm_rpm --run-subtest modeset-pc8-residency-stress IGT-Version: 1.14-g431f6c4 (x86_64) (Linux: 4.4.4-040404-generic x86_64) Runtime PM support: 1 PC8 residency support: 1 (pm_rpm:1234) CRITICAL: Test assertion failure function modeset_subtest, file pm_rpm.c:745: (pm_rpm:1234) CRITICAL: Failed assertion: pc8_plus_residency_changed(120) Stack trace: #0 [__igt_fail_assert+0x101] #1 [modeset_subtest+0x151] #2 [main+0xf08] #3 [__libc_start_main+0xf0] #4 [_start+0x29] #5 [<unknown>+0x29] Subtest modeset-pc8-residency-stress failed. **** DEBUG **** (pm_rpm:1234) DEBUG: Test requirement passed: has_pc8 (pm_rpm:1234) CRITICAL: Test assertion failure function modeset_subtest, file pm_rpm.c:745: (pm_rpm:1234) CRITICAL: Failed assertion: pc8_plus_residency_changed(120) **** END **** Subtest modeset-pc8-residency-stress: FAIL (120.288s)
This issue also occurs on KBL with the following configuration Test cases =============== pm_rpm@modeset-non-lpsp pm_rpm@legacy-planes pm_rpm@modeset-lpsp pm_rpm@i2c pm_rpm@debugfs-read pm_rpm@cursor pm_rpm@pm-tiling pm_rpm@gem-pread pm_rpm@basic-rte Hardware configuration ======================= Platform KBL (RVP3) Motherboard model Kabylake Client platform Motherboard type Skylake Y LPDDR3 RVP3 Laptop Motherboard manufacturer Intel Corporation CPU family Other CPU information Genuine Intel(R) CPU 0000 @ 0.90GHz GPU Card Intel Corporation Device 591e (prog-if 00 [VGA controller]) Memory ram 4 GB Software configuration ======================= --> Component : drm url : http://cgit.freedesktop.org/mesa/drm tag : libdrm-2.4.67-5-gea07de9 commit : ea07de9 author : Rodrigo Vivi <rodrigo.vivi@intel.com> age : 13 days ago --> Component : mesa url : http://cgit.freedesktop.org/mesa/mesa tag : mesa-11.1.2 commit : 7bcd827 author : Emil Velikov <emil.velikov@collabora.com> age : 5 weeks ago --> Component : xf86-video-intel url : http://cgit.freedesktop.org/xorg/driver/xf86-video-intel tag : 2.99.917-560-gd167280 commit : d167280 author : Chris Wilson <chris@chris-wilson.co.uk> age : 3 weeks ago --> Component : libva url : http://cgit.freedesktop.org/libva/ tag : libva-1.7.0.pre1 commit : 35f1447 author : Xiang Haihao <haihao.xiang@intel.com> age : 11 days ago --> Component : vaapi (intel-driver) url : http://cgit.freedesktop.org/vaapi/intel-driver tag : 1.7.0.pre1 commit : ab8e4e3 author : Xiang Haihao <haihao.xiang@intel.com> age : 11 days ago --> Component : cairo url : http://cgit.freedesktop.org/cairo tag : 1.15.2 commit : db8a7f1 author : Bryce Harrington <bryce@osg.samsung.com> age : 3 months ago --> Component : xserver url : http://cgit.freedesktop.org/xorg/xserver tag : xorg-server-1.18.1 commit : 23e60f9 author : Adam Jackson <ajax@redhat.com> age : 5 weeks ago --> Component : intel-gpu-tools url : http://cgit.freedesktop.org/xorg/app/intel-gpu-tools tag : intel-gpu-tools-1.14-23-g364d378 commit : 364d378 author : Paulo Zanoni <paulo.r.zanoni@intel.com> age : 10 days ago kernel configuration ===================== Branch : drm-intel-testing commit a27657a39741599ce9feef1ef39ae6654e9e6768 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Mon Feb 29 09:42:22 2016 +0100 drm-intel-nightly: 2016y-02m-29d-08h-41m-12s UTC integration manifest Kernel version : 4.5.0-rc5 Architecture : source amd64 all
*** Bug 90994 has been marked as a duplicate of this bug. ***
Milestone criteria blocker so increasing priority
Major part of subtest are failing on APL with the following configuration: test cases ================================ igt@pm_rpm@modeset-stress-extra-wait igt@pm_rpm@fences igt@pm_rpm@modeset-lpsp-stress igt@pm_rpm@universal-planes-dpms igt@pm_rpm@basic-pci-d3-state igt@pm_rpm@drm-resources-equal igt@pm_rpm@gem-execbuf igt@pm_rpm@modeset-lpsp igt@pm_rpm@modeset-non-lpsp-stress igt@pm_rpm@gem-execbuf-stress-extra-wait igt@pm_rpm@modeset-non-lpsp igt@pm_rpm@universal-planes igt@pm_rpm@basic-rte igt@pm_rpm@gem-mmap-cpu igt@pm_rpm@cursor-dpms igt@pm_rpm@i2c igt@pm_rpm@legacy-planes-dpms igt@pm_rpm@gem-mmap-gtt igt@pm_rpm@dpms-non-lpsp igt@pm_rpm@reg-read-ioctl igt@pm_rpm@system-suspend igt@pm_rpm@dpms-mode-unset-lpsp igt@pm_rpm@gem-execbuf-stress igt@pm_rpm@cursor igt@pm_rpm@system-suspend-execbuf igt@pm_rpm@sysfs-read igt@pm_rpm@debugfs-read igt@pm_rpm@dpms-mode-unset-non-lpsp igt@pm_rpm@dpms-lpsp igt@pm_rpm@gem-idle igt@pm_rpm@fences-dpms igt@pm_rpm@debugfs-forcewake-user igt@pm_rpm@system-suspend-modeset igt@pm_rpm@legacy-planes igt@pm_rpm@pm-caching igt@pm_rpm@gem-evict-pwrite igt@pm_rpm@gem-pread igt@pm_rpm@pm-tiling Software information ================================ Kernel version : 4.6.0-rc4-drm-intel-nightly-ww17-commit-1e81bac+ Linux distribution : Ubuntu 15.10 Architecture : 64-bit Bios revision : 129.10 KSC revision : 1.6 Hardware information ================================ Platform : BXT-P Motherboard model : Broxton P Motherboard type : NOTEBOOK Hand Held Motherboard manufacturer : Intel Corp. CPU family : Other CPU information : 06/5c GPU Card : Intel Corporation Device 5a84 (rev 03) (prog-if 00 [VGA controller]) Memory ram : 8 GB Maximum memory ram allowed : 16 GB Graphic stack information ================================ --> Component : drm url : http://cgit.freedesktop.org/mesa/drm tag : libdrm-2.4.67-26-g739b888 commit : 739b888 author : Nicolas Dechesne <nicolas.dechesne@linaro.org> age : 2 weeks ago --> Component : mesa url : http://cgit.freedesktop.org/mesa/mesa tag : mesa-11.1.2 commit : 7bcd827 author : Emil Velikov <emil.velikov@collabora.com> age : 3 months ago --> Component : xf86-video-intel url : http://cgit.freedesktop.org/xorg/driver/xf86-video-intel tag : 2.99.917-640-gbca4e0e commit : bca4e0e author : Chris Wilson <chris@chris-wilson.co.uk> age : 2 days ago --> Component : libva url : http://cgit.freedesktop.org/libva/ tag : libva-1.7.0-1-g2339d10 commit : 2339d10 author : Xiang Haihao <haihao.xiang@intel.com> age : 6 weeks ago --> Component : vaapi (intel-driver) url : http://cgit.freedesktop.org/vaapi/intel-driver tag : 1.7.0-8-g2c1bec0 commit : 2c1bec0 author : peng.chen <peng.c.chen@intel.com> age : 3 weeks ago --> Component : cairo url : http://cgit.freedesktop.org/cairo tag : 1.15.2 commit : db8a7f1 author : Bryce Harrington <bryce@osg.samsung.com> age : 5 months ago --> Component : xserver url : http://cgit.freedesktop.org/xorg/xserver tag : xorg-server-1.18.0-291-g16e4bce commit : 16e4bce author : Simon Thum <simon.thum@gmx.de> age : 2 weeks ago --> Component : intel-gpu-tools url : http://cgit.freedesktop.org/xorg/app/intel-gpu-tools tag : intel-gpu-tools-1.14-212-g1e9a3ac commit : 1e9a3ac author : Chris Wilson <chris@chris-wilson.co.uk> age : 3 days ago kernel information ================================ commit 1e81bacf1f7fdbdf83f46b55389713fa13cb1256 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sun Apr 24 11:36:51 2016 +0100 drm-intel-nightly: 2016y-04m-24d-10h-36m-11s UTC integration manifest Kernel version : 4.6.0-rc4 Architecture : source amd64 all Homepage : http://www.kernel.org/
On APL this fails since it depends on the DMC firmware. There is no working BXT firmware available yet, the minimum required firmware version is 1.07 and this will be released only after passing validation.
Also please add links to all the new reports you're filing, and once that's done close this one here as INVALID. And if our bug filing bkms don't document this properly, then please fix that too. And if we have lost our bug filing bkms again, then I'll be pissed ;-)
(In reply to Daniel Vetter from comment #16) > Also please add links to all the new reports you're filing, and once that's > done close this one here as INVALID. > > And if our bug filing bkms don't document this properly, then please fix > that too. > > And if we have lost our bug filing bkms again, then I'll be pissed ;-) Strike this, commented in the wrong bugzilla ... sorry for the noise.
QA, please clean-up this bug. The original bug is about basic-pci-d3-state failing on SNB. A failure with our BAT. Now we have all the pm_rpm failures for all the platforms in this one bug. These are separate issues, requiring dmesg, etc. details.
pm_rpm@basic-pci-d3-state is Pass on KBL, so removed KBL from title and i915 platform.
On APL: bug 96053
Created attachment 126106 [details] dmesg log with drm.debug=14 The igt@pm_rpm@basic-pci-d3-state is still failing on SKL using the below configuration: ( attached dmesg.log using drm.debug=14) Hardware: ============================================================================= Platform: NUC6i3SYB CPU: Intel(R) Core(TM) i3-6100U CPU @ 2.30GHZ (family 6, model 78, stepping 3) Motherboard version: H81132-502 GPU: Intel® HD Graphics 520 - Intel Corporation Sky Lake Integrated Graphics (rev 07) Memory: one 8GB card Kingston KVR21S15D8/8 SSD: Samsung 850 EVO M.2 120 Go Software: ============================================================================= Bios: SYSKLi35.86A.0045.2016.0527.1055 from https://downloadcenter.intel.com/downloads/eula/26097/BIOS-Update-SYSKLi35-86A-?httpDown=https%3A%2F%2Fdownloadmirror.intel.com%2F26097%2Feng%2FSY0045.bio Linux distribution: Ubuntu 16.04 64 bits Kernel: 4.8.0-rc2 f53a8d1 from http://cgit.freedesktop.org/drm-intel/ commit f53a8d1853e8a97ad4a6308ffa8a2011fbd80467 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri Aug 19 17:24:52 2016 +0100 drm-intel-nightly: 2016y-08m-19d-16h-24m-21s UTC integration manifest libdrm-2.4.70-2 b214b05 from git://anongit.freedesktop.org/mesa/drm mesa: mesa-11.2.2 3a9f628from git://anongit.freedesktop.org/mesa/mesa cairo 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo xorg-server-1.18.0- 532 6e5bec2 from git://git.freedesktop.org/git/xorg/xserver xf86-video-intel 2.99.697 12c14de from git://git.freedesktop.org/git/xorg/driver/xf86-video-intel libva-1.7.0-45 b27feb9 from git://git.freedesktop.org/git/vaapi/libva vaapi-intel-driver: 1.7.0-89 b53fad9 from git://git.freedesktop.org/git/vaapi/intel-driver DMC 1.26 from https://01.org/sites/default/files/downloads/intelr-graphics-linux/skldmcver126.tar_1.bz2 GUC 6.1 from https://01.org/sites/default/files/downloads/intelr-graphics-linux/sklgucver61.tar.bz2 Intel-Gpu-Tools 1.15 b0658ce from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git External screens: HDMI: Ctl IP2152 and DP: LG 23MB35PYI
Upgrading priority according to platform gen impact and classification to igt basic. Christophe, Jairo, I would like to indicate that it is passing on FI CI, so please confirm status.
Yann, I see this as we should clean this situation now. Lets avoid smashing multiple architectures into one bug that creates it hard to investigate. Lets make new bug report if there are still issues.
Yann, are you ok with this and can be closed?
(In reply to jani.saarinen from comment #24) > Yann, are you ok with this and can be closed? I am ok, we still see some failure but we are diverging from original bug. Humberto, Christophe, please checked both CI & QA results and fill accordingly new bugs depending on root cause / platform. Then close this one.
I confirm basic-pci-d3-state is Pass on SNB: Platform: HP Z210 Workstation CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz (family 6, model 42, stepping 7) Motherboard version: DQ67SW GPU: Intel® HD Graphics 2000 - Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller (rev 09) Software Bios: SWQ6710H.86A.0060.2011.1220.1805 Linux distribution: Ubuntu 16.04 64 bits Kernel: 4.8.0-rc4 9baa666 from http://cgit.freedesktop.org/drm-intel/ commit 9baa666b3e48f71b46c5f63541f57d2a95a1b1c0 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sat Sep 3 13:12:38 2016 +0100 drm-intel-nightly: 2016y-09m-03d-12h-12m-15s UTC integration manifest libdrm-2.4.70-6 4462303 from git://anongit.freedesktop.org/mesa/drm mesa: mesa-11.2.2 3a9f628from git://anongit.freedesktop.org/mesa/mesa cairo 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo xorg-server-1.18.0-546 deae9c7 from git://git.freedesktop.org/git/xorg/xserver xf86-video-intel 2.99.917-701 205146b from git://git.freedesktop.org/git/xorg/driver/xf86-video-intel libva-1.7.0-47 2ebf897 from git://git.freedesktop.org/git/vaapi/libva vaapi-intel-driver: 1.7.0-95 1817bee from git://git.freedesktop.org/git/vaapi/intel-driver Intel-Gpu-Tools 1.16 6bd4208 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.