| Summary: | volume control in new tunnel modules | ||
|---|---|---|---|
| Product: | PulseAudio | Reporter: | Pierre Ossman <pierre-bugzilla> |
| Component: | modules | Assignee: | pulseaudio-bugs |
| Status: | RESOLVED MOVED | QA Contact: | pulseaudio-bugs |
| Severity: | normal | ||
| Priority: | medium | CC: | lennart, tanuk |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 73426 | ||
| Attachments: |
patch
updated patch deferred volumes delayed volume setting |
||
Created attachment 117088 [details] [review] updated patch Updated patch: - It's bad form to force initial volume on the server, so fetch it the other way instead. - Set that the sink/source has dB volume. That should be correct given that we're not actual hardware, and this also makes flat volumes work properly. Created attachment 117642 [details] [review] deferred volumes An addition to the previous patch. The volume changes need to be deferred so stream access is always done on the same thread (the streams are not thread safe). Created attachment 118309 [details] [review] delayed volume setting And yet another addition. Initial volume handling can be a bit race:y because of the fact that we create the sink/source before we have an active connection. Is anyone looking at these patches (and the other bug entries I've submitted)? Should I send patches some other way? While I would prefer patches on the mailing list, I monitor the bug tracker as well, so no need to resubmit. I'll get to reviewing the patches eventually. Thanks for the patches, and sorry that I can't act on them in a more timely manner. *** Bug 73428 has been marked as a duplicate of this bug. *** -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/381. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 117014 [details] patch We should make sure we are in sync with the sink input/source output on the other side.