Bug 91280 - volume control in new tunnel modules
Summary: volume control in new tunnel modules
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
: 73428 (view as bug list)
Depends on:
Blocks: 73426
  Show dependency treegraph
Reported: 2015-07-09 10:34 UTC by Pierre Ossman
Modified: 2018-07-30 10:22 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

patch (14.93 KB, text/plain)
2015-07-09 10:34 UTC, Pierre Ossman
updated patch (13.67 KB, patch)
2015-07-13 13:23 UTC, Pierre Ossman
Details | Splinter Review
deferred volumes (2.09 KB, patch)
2015-08-12 08:50 UTC, Pierre Ossman
Details | Splinter Review
delayed volume setting (2.32 KB, patch)
2015-09-16 07:36 UTC, Pierre Ossman
Details | Splinter Review

Description Pierre Ossman 2015-07-09 10:34:08 UTC
Created attachment 117014 [details]

We should make sure we are in sync with the sink input/source output on the other side.
Comment 1 Pierre Ossman 2015-07-13 13:23:36 UTC
Created attachment 117088 [details] [review]
updated patch

Updated patch:

 - It's bad form to force initial volume on the server, so fetch it the other way instead.

 - Set that the sink/source has dB volume. That should be correct given that we're not actual hardware, and this also makes flat volumes work properly.
Comment 2 Pierre Ossman 2015-08-12 08:50:00 UTC
Created attachment 117642 [details] [review]
deferred volumes

An addition to the previous patch. The volume changes need to be deferred so stream access is always done on the same thread (the streams are not thread safe).
Comment 3 Pierre Ossman 2015-09-16 07:36:05 UTC
Created attachment 118309 [details] [review]
delayed volume setting

And yet another addition. Initial volume handling can be a bit race:y because of the fact that we create the sink/source before we have an active connection.
Comment 4 Pierre Ossman 2015-09-16 07:37:10 UTC
Is anyone looking at these patches (and the other bug entries I've submitted)? Should I send patches some other way?
Comment 5 Tanu Kaskinen 2015-09-16 08:22:10 UTC
While I would prefer patches on the mailing list, I monitor the bug tracker as well, so no need to resubmit. I'll get to reviewing the patches eventually. Thanks for the patches, and sorry that I can't act on them in a more timely manner.
Comment 6 Fabian Köster 2016-09-13 10:14:55 UTC
*** Bug 73428 has been marked as a duplicate of this bug. ***
Comment 7 GitLab Migration User 2018-07-30 10:22:06 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/381.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.