Bug 91548

Summary:	[PATCH] Add basic support for RichMedia annotations to Qt frontends
Product:	poppler	Reporter:	Tobias Koenig <tobias.koenig>
Component:	qt frontend	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	medium	CC:	oliver.sander
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch to support RichMedia annotations in poppler qt5 frontend Patch to support RichMedia annotations in poppler qt5 frontend Patch to support RichMedia annotations in poppler qt5 frontend Patch to support RichMedia annotations in poppler qt frontends Patch to support RichMedia annotations in poppler qt frontends

Description Tobias Koenig 2015-08-04 06:51:45 UTC

Created attachment 117502 [details]
Patch to support RichMedia annotations in poppler qt5 frontend

The attached patch adds the data structures and conversion code to the Qt5 front end for basic support of RichMedia annotations as described in 'Adobe Supplement to the ISO 32000'.

Since most poppler frontends on Linux cannot support the proper playback of Flash media, this patch retrieves enough information (flash player parameters and filespec to embedded data stream) from the PDF, to allow the front end to extract the actual media (e.g. video or audio) and do the playback by the native media player of the system.

This patch depends on https://bugs.freedesktop.org/show_bug.cgi?id=91547

Comment 1 Tobias Koenig 2015-08-04 08:01:44 UTC

Created attachment 117504 [details] [review]
Patch to support RichMedia annotations in poppler qt5 frontend

Comment 2 Tobias Koenig 2015-08-04 09:08:39 UTC

Created attachment 117506 [details] [review]
Patch to support RichMedia annotations in poppler qt5 frontend

Comment 3 Albert Astals Cid 2015-08-10 21:18:40 UTC

Some more documentation?

Qt4 frontend support?

Comment 4 Tobias Koenig 2015-08-11 09:24:19 UTC

Created attachment 117625 [details] [review]
Patch to support RichMedia annotations in poppler qt frontends

Added API documentation to the new classes, made all setter methods private (since they are used only by AnnotationPrivate anyway) and extended the patch to copy Qt4 frontend as well.

Comment 5 Albert Astals Cid 2015-08-12 20:27:34 UTC

From reading the code i understand that annotConfiguration, annotInstance and annotAsset can be null, should protect against those, no? Or maybe make it on the core so that they are never null and have default valueS?

Comment 6 Tobias Koenig 2015-08-13 06:44:06 UTC

Created attachment 117664 [details] [review]
Patch to support RichMedia annotations in poppler qt frontends

Add safety checks to not access nulled annotConfiguration, annotInstance or annotAsset variables.

Comment 7 Albert Astals Cid 2015-08-13 22:11:27 UTC

Pushed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.