Bug 91547 - [PATCH] Add basic support for RichMedia annotations
Summary: [PATCH] Add basic support for RichMedia annotations
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-04 06:47 UTC by Tobias Koenig
Modified: 2015-08-13 21:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to support RichMedia annotations in poppler core (11.27 KB, text/plain)
2015-08-04 06:47 UTC, Tobias Koenig
Details
Patch to support RichMedia annotations in poppler core (11.33 KB, patch)
2015-08-04 08:01 UTC, Tobias Koenig
Details | Splinter Review
Patch to support RichMedia annotations in poppler core (11.22 KB, patch)
2015-08-04 09:07 UTC, Tobias Koenig
Details | Splinter Review
Patch to support RichMedia annotations in poppler core (14.11 KB, patch)
2015-08-11 09:21 UTC, Tobias Koenig
Details | Splinter Review
Patch to support RichMedia annotations in poppler core (14.22 KB, patch)
2015-08-13 06:42 UTC, Tobias Koenig
Details | Splinter Review

Description Tobias Koenig 2015-08-04 06:47:39 UTC
Created attachment 117501 [details]
Patch to support RichMedia annotations in poppler core

The attached patch adds the data structures and parsing code for basic support of RichMedia annotations as described in 'Adobe Supplement to the ISO 32000'.

Since most poppler frontends on Linux cannot support the proper playback of Flash media, this patch retrieves enough information (flash player parameters and filespec to embedded data stream) from the PDF, to allow the front end to extract the actual media (e.g. video or audio) and do the playback by the native media player of the system.
Comment 1 Tobias Koenig 2015-08-04 08:01:09 UTC
Created attachment 117503 [details] [review]
Patch to support RichMedia annotations in poppler core
Comment 2 Tobias Koenig 2015-08-04 09:07:55 UTC
Created attachment 117505 [details] [review]
Patch to support RichMedia annotations in poppler core
Comment 3 Albert Astals Cid 2015-08-10 21:17:08 UTC
Please implement proper getters.
Comment 4 Tobias Koenig 2015-08-11 09:21:54 UTC
Created attachment 117624 [details] [review]
Patch to support RichMedia annotations in poppler core

Made all members private and added proper getter methods.
Comment 5 Albert Astals Cid 2015-08-12 20:20:18 UTC
Do we want code on 
  AnnotRichMedia::Deactivation::Deactivation
and 
  AnnotRichMedia::Activation::Activation
to assign a condition if there "Condition" but doesn't match any of the 3 if? otherwise it ends up being not initialized, no?

For the rest i'll say i haven't look at the spec but seems straigh-forward enough.
Comment 6 Tobias Koenig 2015-08-13 06:42:16 UTC
Created attachment 117663 [details] [review]
Patch to support RichMedia annotations in poppler core

The new patch ensures that the 'condition' member of Activation and Deactivation is always initialized.
Comment 7 Albert Astals Cid 2015-08-13 21:58:18 UTC
Pushed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.