| Summary: | Add support for Saturn ROMs | ||
|---|---|---|---|
| Product: | shared-mime-info | Reporter: | Adrien Plazas <kekun.plazas> |
| Component: | freedesktop.org.xml | Assignee: | Shared Mime Info group <shared_mime_info> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Add application/x-saturn-rom
Add application/x-saturn-rom Add application/x-saturn-rom |
||
|
Description
Adrien Plazas
2015-08-30 18:51:48 UTC
Created attachment 117997 [details] [review] Add application/x-saturn-rom Comment on attachment 117997 [details] [review] Add application/x-saturn-rom Review of attachment 117997 [details] [review]: ----------------------------------------------------------------- ::: freedesktop.org.xml.in @@ +1635,5 @@ > <generic-icon name="text-x-script"/> > <glob pattern="*.es"/> > </mime-type> > + <mime-type type="application/x-saturn-rom"> > + <_comment>Saturn ROM</_comment> Doesn't it use CDs? ::: tests/list @@ +432,5 @@ > # Video game ROMs > genesis1.bin application/x-genesis-rom xox > genesis2.bin application/x-genesis-rom xox > +# NiGHTS into Dreams truncated to 1Ko > +saturn-test.bin application/x-saturn-rom xox Why does it nearly all fail? Change the name to .sat? Comment on attachment 117997 [details] [review] Add application/x-saturn-rom Review of attachment 117997 [details] [review]: ----------------------------------------------------------------- ::: freedesktop.org.xml.in @@ +1635,5 @@ > <generic-icon name="text-x-script"/> > <glob pattern="*.es"/> > </mime-type> > + <mime-type type="application/x-saturn-rom"> > + <_comment>Saturn ROM</_comment> It does, but as Dreamcast GD-ROMs are labelled as ROMs I thought it was the correct way. (In reply to Adrien Plazas from comment #3) > Comment on attachment 117997 [details] [review] [review] > Add application/x-saturn-rom > > Review of attachment 117997 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: freedesktop.org.xml.in > @@ +1635,5 @@ > > <generic-icon name="text-x-script"/> > > <glob pattern="*.es"/> > > </mime-type> > > + <mime-type type="application/x-saturn-rom"> > > + <_comment>Saturn ROM</_comment> > > It does, but as Dreamcast GD-ROMs are labelled as ROMs I thought it was the > correct way. It's incorrect for Dreamcast disks then ;) Created attachment 118014 [details] [review] Add application/x-saturn-rom Comment on attachment 118014 [details] [review] Add application/x-saturn-rom Review of attachment 118014 [details] [review]: ----------------------------------------------------------------- ::: tests/list @@ +434,5 @@ > # Video game ROMs > genesis1.bin application/x-genesis-rom xox > genesis2.bin application/x-genesis-rom xox > +# NiGHTS into Dreams truncated to 1Ko > +saturn-test.bin application/x-saturn-rom xox Why do the check by magic fail? Created attachment 118018 [details] [review] Add application/x-saturn-rom Comment on attachment 118014 [details] [review] Add application/x-saturn-rom Review of attachment 118014 [details] [review]: ----------------------------------------------------------------- ::: tests/list @@ +434,5 @@ > # Video game ROMs > genesis1.bin application/x-genesis-rom xox > genesis2.bin application/x-genesis-rom xox > +# NiGHTS into Dreams truncated to 1Ko > +saturn-test.bin application/x-saturn-rom xox I doesn't, I just misunderstood what the third check means. commit f7408ea133eae27abce67bbe67a7225d64536008 Author: Adrien Plazas <kekun.plazas@laposte.net> Date: Sat Aug 29 20:06:09 2015 +0200 Add application/x-saturn-rom https://bugs.freedesktop.org/show_bug.cgi?id=91815 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.