Bug 91815 - Add support for Saturn ROMs
Summary: Add support for Saturn ROMs
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Shared Mime Info group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-30 18:51 UTC by Adrien Plazas
Modified: 2015-09-01 10:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Add application/x-saturn-rom (2.85 KB, patch)
2015-08-30 18:52 UTC, Adrien Plazas
Details | Splinter Review
Add application/x-saturn-rom (2.85 KB, patch)
2015-08-31 15:14 UTC, Adrien Plazas
Details | Splinter Review
Add application/x-saturn-rom (2.86 KB, patch)
2015-08-31 17:31 UTC, Adrien Plazas
Details | Splinter Review

Description Adrien Plazas 2015-08-30 18:51:48 UTC
Support for SEGA Saturn ROMs should be added.
Comment 1 Adrien Plazas 2015-08-30 18:52:58 UTC
Created attachment 117997 [details] [review]
Add application/x-saturn-rom
Comment 2 Bastien Nocera 2015-08-31 08:57:44 UTC
Comment on attachment 117997 [details] [review]
Add application/x-saturn-rom

Review of attachment 117997 [details] [review]:
-----------------------------------------------------------------

::: freedesktop.org.xml.in
@@ +1635,5 @@
>      <generic-icon name="text-x-script"/>
>      <glob pattern="*.es"/>
>    </mime-type>
> +  <mime-type type="application/x-saturn-rom">
> +    <_comment>Saturn ROM</_comment>

Doesn't it use CDs?

::: tests/list
@@ +432,5 @@
>  # Video game ROMs
>  genesis1.bin application/x-genesis-rom xox
>  genesis2.bin application/x-genesis-rom xox
> +# NiGHTS into Dreams truncated to 1Ko
> +saturn-test.bin application/x-saturn-rom xox

Why does it nearly all fail? Change the name to .sat?
Comment 3 Adrien Plazas 2015-08-31 14:22:29 UTC
Comment on attachment 117997 [details] [review]
Add application/x-saturn-rom

Review of attachment 117997 [details] [review]:
-----------------------------------------------------------------

::: freedesktop.org.xml.in
@@ +1635,5 @@
>      <generic-icon name="text-x-script"/>
>      <glob pattern="*.es"/>
>    </mime-type>
> +  <mime-type type="application/x-saturn-rom">
> +    <_comment>Saturn ROM</_comment>

It does, but as Dreamcast GD-ROMs are labelled as ROMs I thought it was the correct way.
Comment 4 Bastien Nocera 2015-08-31 14:23:12 UTC
(In reply to Adrien Plazas from comment #3)
> Comment on attachment 117997 [details] [review] [review]
> Add application/x-saturn-rom
> 
> Review of attachment 117997 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: freedesktop.org.xml.in
> @@ +1635,5 @@
> >      <generic-icon name="text-x-script"/>
> >      <glob pattern="*.es"/>
> >    </mime-type>
> > +  <mime-type type="application/x-saturn-rom">
> > +    <_comment>Saturn ROM</_comment>
> 
> It does, but as Dreamcast GD-ROMs are labelled as ROMs I thought it was the
> correct way.

It's incorrect for Dreamcast disks then ;)
Comment 5 Adrien Plazas 2015-08-31 15:14:45 UTC
Created attachment 118014 [details] [review]
Add application/x-saturn-rom
Comment 6 Bastien Nocera 2015-08-31 15:32:29 UTC
Comment on attachment 118014 [details] [review]
Add application/x-saturn-rom

Review of attachment 118014 [details] [review]:
-----------------------------------------------------------------

::: tests/list
@@ +434,5 @@
>  # Video game ROMs
>  genesis1.bin application/x-genesis-rom xox
>  genesis2.bin application/x-genesis-rom xox
> +# NiGHTS into Dreams truncated to 1Ko
> +saturn-test.bin application/x-saturn-rom xox

Why do the check by magic fail?
Comment 7 Adrien Plazas 2015-08-31 17:31:08 UTC
Created attachment 118018 [details] [review]
Add application/x-saturn-rom
Comment 8 Adrien Plazas 2015-08-31 17:32:09 UTC
Comment on attachment 118014 [details] [review]
Add application/x-saturn-rom

Review of attachment 118014 [details] [review]:
-----------------------------------------------------------------

::: tests/list
@@ +434,5 @@
>  # Video game ROMs
>  genesis1.bin application/x-genesis-rom xox
>  genesis2.bin application/x-genesis-rom xox
> +# NiGHTS into Dreams truncated to 1Ko
> +saturn-test.bin application/x-saturn-rom xox

I doesn't, I just misunderstood what the third check means.
Comment 9 Bastien Nocera 2015-09-01 10:21:11 UTC
commit f7408ea133eae27abce67bbe67a7225d64536008
Author: Adrien Plazas <kekun.plazas@laposte.net>
Date:   Sat Aug 29 20:06:09 2015 +0200

    Add application/x-saturn-rom
    
    https://bugs.freedesktop.org/show_bug.cgi?id=91815


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.