Bug 91939

Summary:	configure error
Product:	GeoClue	Reporter:	Bastien Nocera <bugzilla>
Component:	General	Assignee:	Geoclue Bugs <geoclue-bugs>
Status:	RESOLVED FIXED	QA Contact:	Geoclue Bugs <geoclue-bugs>
Severity:	normal
Priority:	medium	CC:	bugzilla, zeenix
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	build: Fix detection of gdbus-codegen tool

Description Bastien Nocera 2015-09-09 14:28:00 UTC

During configure:

checking what language compliance flags to pass to the C compiler... 
./configure: line 13912: dummy: command not found
checking that generated files are newer than configure... done

The error is generate by this hunk of patch from commit 97be2694455675567c09d46914d82d1fc877266a and bug 67858:

+if test "x$GDBUS_CODEGEN" = "x"; then
+       ifelse([$2],,[AC_MSG_ERROR([gdbus-codegen not found.])],[$2])
+else
+       ifelse([$1],,[:],[$1])
+fi

Which expands to:
if test "x$GDBUS_CODEGEN" = "x"; then
        $2
else
        $1
fi

I'm not sure it's supposed to do that.

Comment 1 Philip Withnall 2015-09-09 15:43:55 UTC

Created attachment 118170 [details] [review]
build: Fix detection of gdbus-codegen tool

The code didn’t even make sense. My bad.

Comment 2 Zeeshan Ali 2015-09-09 18:32:03 UTC

Comment on attachment 118170 [details] [review]
build: Fix detection of gdbus-codegen tool

Review of attachment 118170 [details] [review]:
-----------------------------------------------------------------

ack

Comment 3 Philip Withnall 2015-09-09 18:39:00 UTC

(In reply to Zeeshan Ali from comment #2)
> Comment on attachment 118170 [details] [review] [review]
> build: Fix detection of gdbus-codegen tool
> 
> Review of attachment 118170 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ack

Looks like I don’t have permission to push to geoclue.git:

$ git bz push
error: insufficient permission for adding an object to repository database ./objects

fatal: failed to write object
error: unpack failed: unpack-objects abnormal exit
To ssh://git.freedesktop.org/git/geoclue
 ! [remote rejected] HEAD -> master (n/a (unpacker error))
error: failed to push some refs to 'ssh://git.freedesktop.org/git/geoclue'

Comment 4 Zeeshan Ali 2015-09-09 18:47:04 UTC

Attachment 118170 [details] pushed as b496078 - build: Fix detection of gdbus-codegen tool

Comment 5 Zeeshan Ali 2015-09-09 18:47:42 UTC

(In reply to Zeeshan Ali from comment #4)
> Attachment 118170 [details] pushed as b496078 - build: Fix detection of
> gdbus-codegen tool

BTW, Do i have you to thank for making git-bz work with fdo bz? :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.