Created attachment 83770 [details] [review] Port to Makefile.introspection for GIR support Patches coming to improve various bits of the build system, including: • Tidying up GIR Makefile stuff. • Adding vapigen support. • Fixing `make distcheck`. • Fixing the name of the DOAP file.
Created attachment 83771 [details] [review] Use git.mk to auto-generate the .gitignore file
Created attachment 83772 [details] [review] Find gdbus-codegen path from gio-2.0 pkg-config file
Created attachment 83773 [details] [review] Fix name of DOAP file
Created attachment 83774 [details] [review] Add vapigen support
Comment on attachment 83770 [details] [review] Port to Makefile.introspection for GIR support Review of attachment 83770 [details] [review]: ----------------------------------------------------------------- We need to remove introspection and the library altogether. It's a D-Bus service, and there shouldn't be any libraries (the pkg-config file can still be useful to export the service's XML file though).
Comment on attachment 83771 [details] [review] Use git.mk to auto-generate the .gitignore file Review of attachment 83771 [details] [review]: ----------------------------------------------------------------- Yes.
Created attachment 83775 [details] [review] Ensure org.freedesktop.GeoClue2.conf is distributed
Comment on attachment 83772 [details] [review] Find gdbus-codegen path from gio-2.0 pkg-config file Review of attachment 83772 [details] [review]: ----------------------------------------------------------------- Yes.
Comment on attachment 83773 [details] [review] Fix name of DOAP file Review of attachment 83773 [details] [review]: ----------------------------------------------------------------- Haha, yes.
Comment on attachment 83774 [details] [review] Add vapigen support Review of attachment 83774 [details] [review]: ----------------------------------------------------------------- Please remove this.
Comment on attachment 83775 [details] [review] Ensure org.freedesktop.GeoClue2.conf is distributed Review of attachment 83775 [details] [review]: ----------------------------------------------------------------- Yes.
I don’t have commit rights to git.freedesktop.org. I’ll leave the de-libification for Zeeshan.
This bugzilla makes is really hard to tell the patch status. I really think we should use mailing list for patches in case of freedesktop projects.
(In reply to comment #12) > I don’t have commit rights to git.freedesktop.org. Sorry I totally forgot about these patches. Could you please rebase them and 'obsolete' the ones that are obsolete? > I’ll leave the > de-libification for Zeeshan. Already done. :)
Created attachment 90203 [details] [review] Use git.mk to auto-generate the .gitignore file
Created attachment 90204 [details] [review] Find gdbus-codegen path from gio-2.0 pkg-config file
Created attachment 90205 [details] [review] Ensure org.freedesktop.GeoClue2.conf is distributed
(In reply to comment #14) > Sorry I totally forgot about these patches. Could you please rebase them and > 'obsolete' the ones that are obsolete? Rebased and reattached. :-)
Comment on attachment 90203 [details] [review] Use git.mk to auto-generate the .gitignore file Pushed
All pushed. Thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.