Bug 92344

Created attachment 118757 [details] [review]
French Togo rules

Adding rules patch too

> 1. Why are dead keys not working with the local languages symbols? Example:
> <dead_acute> <o> = ó
> <dead_acute> <ɛ> !=  ɛ́

These compose sequences are not yet known, you have to add them.  For the compose sequences in libX11, it looks like this:

<dead_acute> <U025B>                    : "ɛ́"

For testing, you can put the new sequences in a personal ~/.XCompose file.  You have to make sure that they are used, too; by default, Gtk and Qt applications do not use the libX11 compose sequences.  You can change that by setting the environment variables,

GTK_IM_MODULE=xim
QT_IM_MODULE=xim

The libX11 repository is here: http://cgit.freedesktop.org/xorg/lib/libX11
The files where compose sequences are added is nls/en_US.UTF-8/Compose.pre.
Note that compose sequences do not belong to XKB.  I think the best is to send your patch for the compose sequences directly to the xorg-devel mailing list.

For Gtk and Qt, I do not know the location and procedure to submit proposals for new sequences.

> 2. My second question is if it is possible to combine dead keys? Like
> <dead_acute> <dead_tilde> <ɔ> = ɔ̃́

Yes, this is possible:

<dead_acute> <dead_tilde> <U0255>       : "ɔ̃́"

Thanks a lot for info!

Does it mean that the keyboard can be added to XKB independently of the compose sequences?

I'll soon upload an updated patch with some small modifications. Does the rest look okay?

> The files where compose sequences are added is nls/en_US.UTF-8/Compose.pre.

I will try upload a patch both there and GTK/QT to make it work... but why inside 'en_US' in libX11? Will that not be mostly for people from the US?

(In reply to Mats Blakstad from comment #3)

> Does it mean that the keyboard can be added to XKB independently of the
> compose sequences?

Yes.

> I'll soon upload an updated patch with some small modifications. Does the
> rest look okay?

I noticed some missing underscores in the rules.  I also wonder about the override for AD03.  I do not think you need it.
 
> I will try upload a patch both there and GTK/QT to make it work... but why
> inside 'en_US' in libX11? Will that not be mostly for people from the US?

Many countries use the en_US file.  I guess this is determined by nls/locale.dir.pre.  While the required dead keys and letters depend strongly on the language, the actual dead key sequences do so much less.  Of course, not all languages need all sequences, but surplus sequences hurt only little.  Therefore, many languages can share the same compose file.

> I noticed some missing underscores in the rules.

Where?

> Therefore, many languages can share the same compose file.

Sure I agree! Just not very intuitive to know that everyone share 'en_US' :)

By the way, I fount out that Gtk update their compose sequences sporadically from exactly Xorg and en_US.UTF-8:
https://bugzilla.gnome.org/show_bug.cgi?id=756331
https://git.gnome.org/browse/gtk+/tree/gtk/gtkimcontextsimpleseqs.h#n18

Comment on attachment 118757 [details] [review]
French Togo rules

Review of attachment 118757 [details] [review]:
-----------------------------------------------------------------

The tags in the desciption and shortDescripiton should begin with an underscore.

Thanks, commmitted. The missing underscores found. Also, ISO639 code is fixed to be just 'fr'

Created attachment 120941 [details]
Reviewed 'tg' (Togo) file for symbols

We've continued to work on the keyboard, I didn't get any notifications with updates about this issue!

Can you use this last version that I've uploaded now? The euro sign is moved back to same place as French version to keep the keyboards aligned, and some few other small adjustments.

It would be great if you can make sure that I'm notified about changes on this issue!

> ISO639 code is fixed to be just 'fr'

Can we add several language codes here? The keyboard is made to work for several languages, we can add the codes for all of them.

I also need to check up one more detail, would be great if you can confirm that we can update the keyboard.

I also started issue to add the composers needed for this keyboard here:
https://bugs.freedesktop.org/show_bug.cgi?id=93660

I am sorry, I do not know about any way to notify about changes in git, for particular file. You can get notifications from xkb maillist though.

Your new version is committed to git, thanks for contribution.

Regarding the ISO codes - yes, you can add several of them, there are examples in base.xml

Can I only use ISO-codes or is it possible to add language subtags from IANA Language Subtag Registry?
http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry

(In reply to Mats Blakstad from comment #12)
> Can I only use ISO-codes or is it possible to add language subtags from IANA
> Language Subtag Registry?
> http://www.iana.org/assignments/language-subtag-registry/language-subtag-
> registry

I am afraid, we are using only ISO codes - so that GUI tools could easily lookup them (with localized descriptions).

Okay, I've added patch to update language codes here;
https://bugs.freedesktop.org/show_bug.cgi?id=100623