Bug 92341 - Add Azerty French layout
Summary: Add Azerty French layout
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-08 04:49 UTC by Mats Blakstad
Modified: 2016-01-24 21:30 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
French azerty symbols (3.84 KB, text/plain)
2015-10-08 04:49 UTC, Mats Blakstad
Details
French azerty symbols - version 2 (3.88 KB, patch)
2015-10-08 07:31 UTC, Mats Blakstad
Details | Splinter Review
French azerty rules (492 bytes, patch)
2015-10-08 07:40 UTC, Mats Blakstad
Details | Splinter Review
French azerty rules (494 bytes, patch)
2015-10-15 07:50 UTC, Mats Blakstad
Details | Splinter Review
Patch to fix the unfinished symbols/fr file (613 bytes, patch)
2016-01-22 17:16 UTC, Quentin "Sardem FF7" Glidic
Details | Splinter Review

Description Mats Blakstad 2015-10-08 04:49:12 UTC
Created attachment 118747 [details]
French azerty symbols

Here is patch for the normal french azerty layout

On my Ubuntu I also need to add the layout to 'evdev.xml', however, I'm unable to find it in the repo, where should this be added?

        <variant>
          <configItem>
            <name>azerty</name>
            <description>French (Azerty)</description>
          </configItem>
        </variant>
Comment 1 Andreas Wettstein 2015-10-08 07:09:59 UTC
> On my Ubuntu I also need to add the layout to 'evdev.xml', however, I'm unable > to find it in the repo, where should this be added?

evdev.xml is created from rules/base.xml.in.

I wonder, what is the benefit of this layout?  It seems a strict subset of the "basic" french layout, except that it has a dead grave on AE07, while the basic layout has a normal grave, which is what the image you give as your source suggests (dead keys are in red).  Also, your layout uses three levels, but does not assign a third level chooser, so it becomes usable only after users select an appropriate option.  For comparison, the basic layout has the line

 include "level3(ralt_switch)"

to assign the right Alt key as third level chooser.
Comment 2 Mats Blakstad 2015-10-08 07:31:00 UTC
Created attachment 118750 [details] [review]
French azerty symbols - version 2

French azerty symbols - version 2

I've corrected the dead grave in new patch and added:
 include "level3(ralt_switch)"

The benefit is to be able to use a strict subset of the "basic" French layout, and also to easily include it in new keyboard layouts (that I was recommended to do on xkb email list.
Comment 3 Mats Blakstad 2015-10-08 07:40:00 UTC
Created attachment 118751 [details] [review]
French azerty rules

Adding rules patch
Comment 4 Andreas Wettstein 2015-10-08 08:20:26 UTC
Comment on attachment 118751 [details] [review]
French azerty rules

Review of attachment 118751 [details] [review]:
-----------------------------------------------------------------

The underscores in the _description tags in base.xml.in are missing.
Comment 5 Mats Blakstad 2015-10-15 07:50:58 UTC
Created attachment 118883 [details] [review]
French azerty rules

uups, thanks, okay trying again! :)
Comment 6 Sergey V. Udaltsov 2015-12-14 00:07:16 UTC
Thank you, Mats and Andreas. It is in git now.
Comment 7 Quentin "Sardem FF7" Glidic 2016-01-22 17:16:40 UTC
Created attachment 121211 [details] [review]
Patch to fix the unfinished symbols/fr file

The pushed patch is missing the closing "};" at the end of the section. Here is a trivial patch to fix that.
Comment 8 Sergey V. Udaltsov 2016-01-24 21:30:40 UTC
> The pushed patch is missing the closing "};" at the end of the section. Here
> is a trivial patch to fix that.
Thank you for the fix, missed that!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.