| Summary: | GClueClientInfo tries to load properties of system org.freedesktop.DBus | ||
|---|---|---|---|
| Product: | GeoClue | Reporter: | Tristan Van Berkom <tristan.van.berkom> |
| Component: | General | Assignee: | Geoclue Bugs <geoclue-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Geoclue Bugs <geoclue-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | zeenix |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Avoid loading properties of org.freedesktop.DBus
client-info: Don't load props of /org/freedesktop/DBus |
||
Created attachment 119950 [details] [review] client-info: Don't load props of /org/freedesktop/DBus By default, glib's GDBusProxy calls org.freedesktop.DBus.Properties.GetAll to load all properties on a loaded interface - however in this case we are creating a proxy to the system standard bus interface for the sole purpose of later calling GetConnectionUnixUser. GeoClue does not have permission to use the org.freedesktop.DBus.Properties interface on a proxy to /org/freedesktop/DBus (and there are no properties to be loaded anyway). Note that GeoClue works fine without this patch, however this patch will avoid error messages being logged to the system logs. Comment on attachment 119733 [details]
Avoid loading properties of org.freedesktop.DBus
I fixed/updated the git commit. Please let me know if i instead made it wrong. :)
Comment on attachment 119950 [details] [review] client-info: Don't load props of /org/freedesktop/DBus Review of attachment 119950 [details] [review]: ----------------------------------------------------------------- Heh, Of course, your changes to the commit message did not break the proposed one line change :) Your summary is also more accurate. Attachment 119950 [details] pushed as 45593fe - client-info: Don't load props of /org/freedesktop/DBus
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 119733 [details] Avoid loading properties of org.freedesktop.DBus As mentioned in the commit message of the attached patch; GeoClue works fine without this, but this patch will avoid some misleading error messages in the system logs (error messages which are likely to confuse system integrators while trying to integrate geoclue properly).