| Summary: | edid-decode considers strings with spaces inside as improperly terminated | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Daniel Kamil Kozar <dkk089> | ||||
| Component: | App/edid-decode | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | normal | ||||||
| Priority: | medium | CC: | ajax | ||||
| Version: | git | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
It appears this was fixed by just accepting space, not other printable whitespace characters, in: https://git.linuxtv.org/edid-decode.git/commit/edid-decode.c?id=57c73067385e0bd29d0a67fd73db4ebecc8fb084 Thanks for the report and offering a patch. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 120490 [details] Patch fixing the bug The E-EDID v1.4 specification does not forbid spaces from occuring in strings. However, isgraph() for a space returns false and causes the program to treat a string containing a space before the terminating newline as improperly terminated. Besides, the previous commit touching that line meant to 'allow anything printable', which is exactly what isprint() does. The EDID from a Dell U2715H connected via DisplayPort is attached. It can be used for reproducing the bug.