Bug 93366 - edid-decode considers strings with spaces inside as improperly terminated
Summary: edid-decode considers strings with spaces inside as improperly terminated
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/edid-decode (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-14 00:40 UTC by Daniel Kamil Kozar
Modified: 2018-08-12 20:52 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch fixing the bug (1.72 KB, text/plain)
2015-12-14 00:40 UTC, Daniel Kamil Kozar 		no flags Details
View All

Description Daniel Kamil Kozar 2015-12-14 00:40:58 UTC 
Created attachment 120490 [details]
Patch fixing the bug

The E-EDID v1.4 specification does not forbid spaces from occuring in strings.
However, isgraph() for a space returns false and causes the program to treat a string containing a space before the terminating newline as improperly terminated. Besides, the previous commit touching that line meant to 'allow anything printable', which is exactly what isprint() does.

The EDID from a Dell U2715H connected via DisplayPort is attached. It can be used for reproducing the bug.
Comment 1 Alan Coopersmith 2018-08-12 20:52:02 UTC 
It appears this was fixed by just accepting space, not other printable 
whitespace characters, in:
https://git.linuxtv.org/edid-decode.git/commit/edid-decode.c?id=57c73067385e0bd29d0a67fd73db4ebecc8fb084

Thanks for the report and offering a patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.