Bug 93602

Summary:	[regression] CTS and dEQP uniform_block.random.all_shared_buffer tests fail
Product:	Mesa	Reporter:	Mark Janes <mark.a.janes>
Component:	Drivers/DRI/i965	Assignee:	Mark Janes <mark.a.janes>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	blocker
Priority:	highest	CC:	mark.a.janes, marta.lofstedt
Version:	git
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Mark Janes 2016-01-06 05:03:28 UTC

mesa 8cf2e89 regressed GL conformance and related dEQP tests on: snb, ivb, byt, hsw, skl, bsw, bdw

CTS tests:
es3-cts.shaders.uniform_block.random.all_shared_buffer.1
es3-cts.shaders.uniform_block.random.all_shared_buffer.3
es3-cts.shaders.uniform_block.random.all_shared_buffer.4
es3-cts.shaders.uniform_block.random.all_shared_buffer.5
es3-cts.shaders.uniform_block.random.all_shared_buffer.6
es3-cts.shaders.uniform_block.random.all_shared_buffer.9
es3-cts.shaders.uniform_block.random.all_shared_buffer.11
es3-cts.shaders.uniform_block.random.all_shared_buffer.13
es3-cts.shaders.uniform_block.random.all_shared_buffer.15
es3-cts.shaders.uniform_block.random.all_shared_buffer.16
es3-cts.shaders.uniform_block.random.all_shared_buffer.17
es3-cts.shaders.uniform_block.random.all_shared_buffer.18

Sample output:
/tmp/build_root/m64/bin/cts/glcts --deqp-case=ES3-CTS.shaders.uniform_block.random.all_shared_buffer.6
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
  target implementation = 'intel-gbm'

Test case 'ES3-CTS.shaders.uniform_block.random.all_shared_buffer.6'..
Vertex compile time = 7.033000 ms
Fragment compile time = 2.838000 ms
Link time = 207.371002 ms
  Fail (Image compare failed)

dEQP regressions:
deqp-gles3.functional.ubo.random.all_shared_buffer.0
deqp-gles3.functional.ubo.random.all_shared_buffer.1
deqp-gles3.functional.ubo.random.all_shared_buffer.2
deqp-gles3.functional.ubo.random.all_shared_buffer.3
deqp-gles3.functional.ubo.random.all_shared_buffer.4
deqp-gles3.functional.ubo.random.all_shared_buffer.7
deqp-gles3.functional.ubo.random.all_shared_buffer.8
deqp-gles3.functional.ubo.random.all_shared_buffer.9
deqp-gles3.functional.ubo.random.all_shared_buffer.10
deqp-gles3.functional.ubo.random.all_shared_buffer.14
deqp-gles3.functional.ubo.random.all_shared_buffer.16
deqp-gles3.functional.ubo.random.all_shared_buffer.17
deqp-gles3.functional.ubo.random.all_shared_buffer.18
deqp-gles3.functional.ubo.random.all_shared_buffer.19
deqp-gles3.functional.ubo.random.all_shared_buffer.20
deqp-gles3.functional.ubo.random.all_shared_buffer.21
deqp-gles3.functional.ubo.random.all_shared_buffer.24
deqp-gles3.functional.ubo.random.all_shared_buffer.25
deqp-gles3.functional.ubo.random.all_shared_buffer.26
deqp-gles3.functional.ubo.random.all_shared_buffer.28
deqp-gles3.functional.ubo.random.all_shared_buffer.29
deqp-gles3.functional.ubo.random.all_shared_buffer.30
deqp-gles3.functional.ubo.random.all_shared_buffer.31
deqp-gles3.functional.ubo.random.all_shared_buffer.32
deqp-gles3.functional.ubo.random.all_shared_buffer.34
deqp-gles3.functional.ubo.random.all_shared_buffer.36
deqp-gles3.functional.ubo.random.all_shared_buffer.37
deqp-gles3.functional.ubo.random.all_shared_buffer.38
deqp-gles3.functional.ubo.random.all_shared_buffer.39
deqp-gles3.functional.ubo.random.all_shared_buffer.41
deqp-gles3.functional.ubo.random.all_shared_buffer.42
deqp-gles3.functional.ubo.random.all_shared_buffer.43
deqp-gles3.functional.ubo.random.all_shared_buffer.44
deqp-gles3.functional.ubo.random.all_shared_buffer.45
deqp-gles3.functional.ubo.random.all_shared_buffer.46
deqp-gles3.functional.ubo.random.all_shared_buffer.47
deqp-gles3.functional.ubo.random.all_shared_buffer.48
deqp-gles3.functional.ubo.random.all_shared_buffer.49

sample output:
/tmp/build_root/m64/opt/deqp/modules/gles3/deqp-gles3 --deqp-case=dEQP-GLES3.functional.ubo.random.all_shared_buffer.10 --deqp-surface-type=fbo --deqp-log-images=disable --deqp-surface-width=256 --deqp-surface-height=256
dEQP Core 2014.x (0xcafebabe) starting..
  target implementation = 'DRM'

Test case 'dEQP-GLES3.functional.ubo.random.all_shared_buffer.10'..
Vertex shader compile time = 5.857000 ms
Fragment shader compile time = 2.124000 ms
Link time = 75.835999 ms
Test case duration in microseconds = 93284 us
  Fail (Image compare failed)

Comment 1 Mark Janes 2016-01-06 05:05:02 UTC

Author:     Samuel Iglesias Gonsálvez <siglesias@igalia.com>
AuthorDate: Tue Dec 15 12:51:48 2015 +0100
Commit:     Samuel Iglesias Gonsálvez <siglesias@igalia.com>
CommitDate: Mon Jan 4 07:52:24 2016 +0100

    i965/wm: use proper API buffer size for the surfaces.
    
    Commit 5bb5eeea fixes a bug indicating that the surfaces should have the
    API buffer size. Hovewer it picked the wrong value.
    
    This patch adds a new variable, which takes into account
    glBindBufferRange() values. This patch fixes the following CTS
    regressions:
    
    ES31-CTS.shader_storage_buffer_object.advanced-unsizedArrayLength-cs-std430-vec-bindrangeOffset
    ES31-CTS.shader_storage_buffer_object.advanced-unsizedArrayLength-cs-std430-vec-bindrangeSize
    
    Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
    Reviewed-by: Marta Lofstedt <marta.lofstedt@intel.com>

Comment 2 Mark Janes 2016-01-06 13:49:57 UTC

fixed by a1d664a0b7dbd8bbab0ff7a179e8960c25a52c0b

Comment 3 G Murali Madhav 2016-05-06 05:57:51 UTC

Hi,

I didn't get where to apply the patch.
I also has same problem, pl let me what changes are to made and on which file.

Comment 4 Mark Janes 2016-05-06 06:11:45 UTC

(In reply to G Murali Madhav from comment #3)
> Hi,
> 
> I didn't get where to apply the patch.
> I also has same problem, pl let me what changes are to made and on which
> file.

https://lists.freedesktop.org/archives/mesa-commit/2016-January/061110.html

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.