Bug 93605

Summary: [PATCH] module-tunnel: Fix double free
Product: PulseAudio Reporter: KimJeongYeon <jeongyeon.kim>
Component: modulesAssignee: pulseaudio-bugs
Status: RESOLVED FIXED QA Contact: pulseaudio-bugs
Severity: critical    
Priority: medium CC: lennart
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: [PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed.
[PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed. (upload patch again)

Description KimJeongYeon 2016-01-06 08:42:44 UTC
Created attachment 120826 [details]
[PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed.

Dear all,

Local pointer 'dn' freed again when pa_thread_new() failed in module-tunnel.c.
Please find attached patch and review it. Thanks.

Regards,
KimJeongYeon
Comment 1 Arun Raghavan 2016-01-06 10:10:26 UTC
Thanks for the patch. I think it would be better to just move the pa_xfree(dn) a few lines below to where the other free happens (after the last 'goto fail').
Comment 2 KimJeongYeon 2016-01-06 23:27:43 UTC
Created attachment 120846 [details] [review]
[PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed. (upload patch again)

Thanks for review. I uploaded the patch again.
Comment 3 Arun Raghavan 2016-01-07 12:33:18 UTC
Merged, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.