Bug 93639

Summary:	[PATCH] memblock: Fix double lock/unlock
Product:	PulseAudio	Reporter:	KimJeongYeon <jeongyeon.kim>
Component:	core	Assignee:	pulseaudio-bugs
Status:	RESOLVED NOTABUG	QA Contact:	pulseaudio-bugs
Severity:	critical
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	pa_memexport_process_release() was self-locked function, but some caller used lock/unlock again. (e.g pa_memexport_free(), memexport_revoke_blocks())

Description KimJeongYeon 2016-01-08 03:36:46 UTC

Created attachment 120888 [details] [review]
pa_memexport_process_release() was self-locked function, but some caller used lock/unlock again. (e.g pa_memexport_free(), memexport_revoke_blocks())

Dear all,

pa_memexport_process_release() was self-locked function, but some caller used lock/unlock again outside of it. (e.g pa_memexport_free(), memexport_revoke_blocks())
Therefore, it seems to be occurred double lock/unlock problem.

Would you please review the patch?

Regards,
KimJeongYeon

Comment 1 Arun Raghavan 2016-01-08 03:43:42 UTC

Is this actually a problem? The mutex is recursive, so multiple lock/unlock calls in the same thread should be just fine.

Comment 2 KimJeongYeon 2016-01-08 04:09:23 UTC

(In reply to Arun Raghavan from comment #1)
> Is this actually a problem? The mutex is recursive, so multiple lock/unlock
> calls in the same thread should be just fine.

I confused, please ignore this item.
Thank you for your feedback.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.