Bug 93639 - [PATCH] memblock: Fix double lock/unlock
Summary: [PATCH] memblock: Fix double lock/unlock
Status: RESOLVED NOTABUG
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium critical
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-08 03:36 UTC by KimJeongYeon
Modified: 2016-01-08 04:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
pa_memexport_process_release() was self-locked function, but some caller used lock/unlock again. (e.g pa_memexport_free(), memexport_revoke_blocks()) (3.71 KB, patch)
2016-01-08 03:36 UTC, KimJeongYeon 		Details | Splinter Review
View All

Description KimJeongYeon 2016-01-08 03:36:46 UTC 
Created attachment 120888 [details] [review]
pa_memexport_process_release() was self-locked function, but some caller used lock/unlock again. (e.g pa_memexport_free(), memexport_revoke_blocks())

Dear all,

pa_memexport_process_release() was self-locked function, but some caller used lock/unlock again outside of it. (e.g pa_memexport_free(), memexport_revoke_blocks())
Therefore, it seems to be occurred double lock/unlock problem.

Would you please review the patch?

Regards,
KimJeongYeon
Comment 1 Arun Raghavan 2016-01-08 03:43:42 UTC 
Is this actually a problem? The mutex is recursive, so multiple lock/unlock calls in the same thread should be just fine.
Comment 2 KimJeongYeon 2016-01-08 04:09:23 UTC 
(In reply to Arun Raghavan from comment #1)
> Is this actually a problem? The mutex is recursive, so multiple lock/unlock
> calls in the same thread should be just fine.

I confused, please ignore this item.
Thank you for your feedback.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.