| Summary: | ctcp: Don't bling the non-bling | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Florian Müllner <fmuellner> |
| Component: | idle | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | ctcp: Don't bling the non-bling | ||
|
Description
Florian Müllner
2016-02-17 02:51:57 UTC
Created attachment 121797 [details] [review] ctcp: Don't bling the non-bling When stripping color codes, we currently remove any sequence of digits following ^C. As color codes use at most two digits, this means that we also remove any numbers at the start of the colored text - make sure we stop doing that and only remove digits that are actually part of a color code. Comment on attachment 121797 [details] [review] ctcp: Don't bling the non-bling Review of attachment 121797 [details] [review]: ----------------------------------------------------------------- Looks good to me. Test suite passes, and I can't spot anything obviously wrong. Thanks, Florian. Pushed to master and telepathy-idle-0.2. Can we get a new upstream release of telepathy-idle, to help get the fix out into distros and to end users? (In reply to Marius Gedminas from comment #4) > Can we get a new upstream release of telepathy-idle, to help get the fix out > into distros and to end users? That's reasonable. I'm working on it. Unfortunately it's been so long since there's been a release some of the unit tests are failing. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.