Bug 94189 - ctcp: Don't bling the non-bling
Summary: ctcp: Don't bling the non-bling
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: idle (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-17 02:51 UTC by Florian Müllner
Modified: 2017-11-05 03:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
ctcp: Don't bling the non-bling (1.29 KB, patch)
2016-02-17 02:52 UTC, Florian Müllner 		Details | Splinter Review
View All

Description Florian Müllner 2016-02-17 02:51:57 UTC 
See patch.

(Originally reported as https://bugzilla.gnome.org/show_bug.cgi?id=761957)
Comment 1 Florian Müllner 2016-02-17 02:52:01 UTC 
Created attachment 121797 [details] [review]
ctcp: Don't bling the non-bling

When stripping color codes, we currently remove any sequence of digits
following ^C. As color codes use at most two digits, this means that we
also remove any numbers at the start of the colored text - make sure we
stop doing that and only remove digits that are actually part of a color
code.
Comment 2 Debarshi Ray 2016-02-25 15:48:24 UTC 
Comment on attachment 121797 [details] [review]
ctcp: Don't bling the non-bling

Review of attachment 121797 [details] [review]:
-----------------------------------------------------------------

Looks good to me. Test suite passes, and I can't spot anything obviously wrong. Thanks, Florian.
Comment 3 Debarshi Ray 2016-02-25 16:05:54 UTC 
Pushed to master and telepathy-idle-0.2.
Comment 4 Marius Gedminas 2017-10-27 14:18:07 UTC 
Can we get a new upstream release of telepathy-idle, to help get the fix out into distros and to end users?
Comment 5 diane 2017-11-05 03:54:06 UTC 
(In reply to Marius Gedminas from comment #4)
> Can we get a new upstream release of telepathy-idle, to help get the fix out
> into distros and to end users?

That's reasonable.

I'm working on it. Unfortunately it's been so long since there's been a release some of the unit tests are failing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.