| Summary: | polkit: Add g_autoptr() support for GObject-derived polkit types | ||
|---|---|---|---|
| Product: | PolicyKit | Reporter: | Philip Withnall <bugzilla> |
| Component: | libpolkit | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | David Zeuthen (not reading bugmail) <zeuthen> |
| Severity: | normal | ||
| Priority: | medium | CC: | walters |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | polkit: Add g_autoptr() support for GObject-derived polkit types | ||
|
Description
Philip Withnall
2016-04-22 11:36:01 UTC
Created attachment 123147 [details] [review] polkit: Add g_autoptr() support for GObject-derived polkit types Add G_DEFINE_AUTOPTR_CLEANUP_FUNC calls to polkittypes.h, so that g_autoptr() can be used with polkit objects. This is conditional on GLib ≥ 2.44.0 being available. It does not bump polkit’s dependency on GLib. Comment on attachment 123147 [details] [review] polkit: Add g_autoptr() support for GObject-derived polkit types Review of attachment 123147 [details] [review]: ----------------------------------------------------------------- Are other projects doing things like this? It seems okay, I can see potential maintenance pain as types are added, but in the case of polkit that's very unlikely now. Basically LGTM (In reply to Colin Walters from comment #2) > Comment on attachment 123147 [details] [review] [review] > polkit: Add g_autoptr() support for GObject-derived polkit types > > Review of attachment 123147 [details] [review] [review]: > ----------------------------------------------------------------- > > Are other projects doing things like this? It seems okay, I can see > potential maintenance pain as types are added, but in the case of polkit > that's very unlikely now. > > Basically LGTM I don’t have permission to push this; can you do so please? Looks like this broke at least xdg-app: http://build.gnome.org/continuous/buildmaster/builds/2016/05/07/6/build/log-xdg-app.txt Which given https://bugzilla.gnome.org/show_bug.cgi?id=763379 is probably xdg-app's fault. Just noting here. Commited a fix to xdg-app. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.