Created attachment 123147 [details] [review]
polkit: Add g_autoptr() support for GObject-derived polkit types

Add G_DEFINE_AUTOPTR_CLEANUP_FUNC calls to polkittypes.h, so that
g_autoptr() can be used with polkit objects.

This is conditional on GLib ≥ 2.44.0 being available. It does not bump
polkit’s dependency on GLib.

Comment on attachment 123147 [details] [review]
polkit: Add g_autoptr() support for GObject-derived polkit types

Review of attachment 123147 [details] [review]:
-----------------------------------------------------------------

Are other projects doing things like this?  It seems okay, I can see potential maintenance pain as types are added, but in the case of polkit that's very unlikely now.

Basically LGTM

(In reply to Colin Walters from comment #2)
> Comment on attachment 123147 [details] [review] [review]
> polkit: Add g_autoptr() support for GObject-derived polkit types
> 
> Review of attachment 123147 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> Are other projects doing things like this?  It seems okay, I can see
> potential maintenance pain as types are added, but in the case of polkit
> that's very unlikely now.
> 
> Basically LGTM

I don’t have permission to push this; can you do so please?

https://cgit.freedesktop.org/polkit/commit/?id=004bd37d0b33eb39372bd0e0bed8ab9c1ac2c50c

Looks like this broke at least xdg-app:

http://build.gnome.org/continuous/buildmaster/builds/2016/05/07/6/build/log-xdg-app.txt

Which given https://bugzilla.gnome.org/show_bug.cgi?id=763379 is probably xdg-app's fault.

Just noting here.

Commited a fix to xdg-app.