Bug 9566

Created attachment 8323 [details] [review]
Alternate version comparison

I prefer the compare_versions() function from gnome-autogen.sh:

compare_versions() {
    ch_min_version=$1
    ch_actual_version=$2
    ch_status=0
    IFS="${IFS=         }"; ch_save_IFS="$IFS"; IFS="."
    set $ch_actual_version
    for ch_min in $ch_min_version; do
        ch_cur=`echo $1 | sed 's/[^0-9].*$//'`; shift # remove letter suffixes
        if [ -z "$ch_min" ]; then break; fi
        if [ -z "$ch_cur" ]; then ch_status=1; break; fi
        if [ $ch_cur -gt $ch_min ]; then break; fi
        if [ $ch_cur -lt $ch_min ]; then ch_status=1; break; fi
    done
    IFS="$ch_save_IFS"
    return $ch_status
}

Created attachment 8340 [details] [review]
gnome style check version

Indeed, I much preferred their script over my quick 'get cairo building' hack.

Carl, see if you like the autogen.sh output with the patch committed.

Are we sending automake patches upstream with this?

I really don't understand why every project in the world should continue
to grow such horrendous piles of bootstrapping code when the build system
should provide that itself.

End of rant.

-Carl

Well, it does, and it's called autoreconf.  It just isn't old enough to depend
on.  sigh...

Committed now. 38c9909e2948f089bbec89e2d43b0e6f930c1ab1