|Summary:||Remove unused include header on Windows|
|Product:||dbus||Reporter:||Ralf Habacker <ralf.habacker>|
|Component:||core||Assignee:||D-Bus Maintainers <dbus>|
|Status:||RESOLVED FIXED||QA Contact:||D-Bus Maintainers <dbus>|
|Whiteboard:||review+, waiting for fd.o git|
|i915 platform:||i915 features:|
|Bug Depends on:||97014|
|Attachments:||dbus: do not include afxres.h|
Description Ralf Habacker 2016-05-25 08:54:32 UTC
Created attachment 124078 [details] [review] dbus: do not include afxres.h The KDE on Windows build system for dbus (see https://quickgit.kde.org/?p=emerge.git&a=tree&hb=cf35d49f4585165da530fa885f27f62e4ba572c3&h=252b5c5369ed178f6d04d1f0a09a572563e93281&f=portage%2Fwin32libs%2Fdbus) contains a patch, which removes an unused include header.
Comment 1 Simon McVittie 2016-07-01 16:36:08 UTC
I have no objection to this if you want to apply it. You're better able to test whether it could break anything on Windows than I am.
Comment 2 Ralf Habacker 2016-07-21 11:45:37 UTC
(In reply to Simon McVittie from comment #1) > I have no objection to this if you want to apply it. You're better able to > test whether it could break anything on Windows than I am. I tried to push this change to branch master and got the following error: git push Counting objects: 4, done. Delta compression using up to 4 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 464 bytes | 0 bytes/s, done. Total 4 (delta 3), reused 0 (delta 0) remote: error: insufficient permission for adding an object to repository database objects remote: fatal: failed to write object error: unpack failed: unpack-objects abnormal exit To git+ssh://firstname.lastname@example.org/git/dbus/dbus ! [remote rejected] master -> master (unpacker error) error: failed to push some refs to 'git+ssh://email@example.com/git/dbus/dbus' Ay idea what's going wrong ?
Comment 3 Simon McVittie 2016-07-21 11:47:53 UTC
(In reply to Ralf Habacker from comment #2) > remote: error: insufficient permission for adding an object to repository > database objects Seems to be server-side breakage, I get the same: Bug #97014.
Comment 4 Ralf Habacker 2016-07-25 10:33:15 UTC
Comment on attachment 124078 [details] [review] dbus: do not include afxres.h committed to github.com repo branch master.
Comment 5 Simon McVittie 2016-07-25 10:35:57 UTC
Temporarily reopening this until we can push a fix to the official location
Comment 6 Simon McVittie 2016-07-25 11:54:29 UTC
Now really fixed in git for 1.11.4.