| Summary: | twisted tests do not run with recent glib - FakeNetworkMonitor doesn't implement property 'network-metered' | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | George Kiagiadakis <gkiagia> |
| Component: | mission-control | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
George Kiagiadakis
2016-07-01 15:18:36 UTC
Proposed fix: https://github.com/gkiagia/telepathy-mission-control/commit/71ee133efaaf209c8cc7b66016e2c0fd2f23f17c https://github.com/gkiagia/telepathy-mission-control/commit/80d69d6f77c2043ab3cf6854e108ad1422b23c64 The changes look valid, and many tests that fail before the applying the commits below, pass after applying. Also running tests is a lot faster (theres far fewer timeout errors) +1 commit e732563380bda697c468b591ed126932b022d97f Author: George Kiagiadakis <gkiagia@tolabaki.gr> Date: Fri Jul 1 18:43:28 2016 +0300 configure: bump glib version requirement to 2.46 required for the fake-network-monitor in the unit tests https://bugs.freedesktop.org/show_bug.cgi?id=96763 Reviewed-by: Diane Trout <diane@ghic.org> commit d3e011a2dfaf6ecb41651de7ccc0d2bb520f3208 Author: George Kiagiadakis <gkiagia@tolabaki.gr> Date: Fri Jul 1 18:31:21 2016 +0300 tests/twisted/fake-network-monitor: implement the "network-metered" and "connectivity" properties of GNetworkMonitor "connectivity" is required since glib 2.44 "network-metered" is required since glib 2.46 https://bugs.freedesktop.org/show_bug.cgi?id=96763 Reviewed-by: Diane Trout <diane@ghic.org> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.