Bug 96763 - twisted tests do not run with recent glib - FakeNetworkMonitor doesn't implement property 'network-metered'
Summary: twisted tests do not run with recent glib - FakeNetworkMonitor doesn't implem...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-01 15:18 UTC by George Kiagiadakis
Modified: 2016-07-13 14:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description George Kiagiadakis 2016-07-01 15:18:36 UTC 
Twisted tests fail with mc-debug-server's output being:

(process:29388): GLib-GObject-CRITICAL **: Object class FakeNetworkMonitor doesn't implement property 'network-metered' from interface 'GNetworkMonitor'
Comment 2 diane 2016-07-03 17:46:38 UTC 
The changes look valid, and many tests that fail before the applying the commits below, pass after applying.

Also running tests is a lot faster (theres far fewer timeout errors)
 
+1
Comment 3 George Kiagiadakis 2016-07-13 14:18:44 UTC 
commit e732563380bda697c468b591ed126932b022d97f
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date:   Fri Jul 1 18:43:28 2016 +0300

    configure: bump glib version requirement to 2.46
    
    required for the fake-network-monitor in the unit tests
    
    https://bugs.freedesktop.org/show_bug.cgi?id=96763
    Reviewed-by: Diane Trout <diane@ghic.org>

commit d3e011a2dfaf6ecb41651de7ccc0d2bb520f3208
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date:   Fri Jul 1 18:31:21 2016 +0300

    tests/twisted/fake-network-monitor: implement the "network-metered" and "connectivity" properties of GNetworkMonitor
    
    "connectivity" is required since glib 2.44
    "network-metered" is required since glib 2.46
    
    https://bugs.freedesktop.org/show_bug.cgi?id=96763
    Reviewed-by: Diane Trout <diane@ghic.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.