Bug 96822

Summary:	module-echo-cancel: DOC aec_method='webrtc', mic_geometry coordinates are relative to center
Product:	PulseAudio	Reporter:	Antonio Ospite <ao2>
Component:	modules	Assignee:	pulseaudio-bugs
Status:	RESOLVED FIXED	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Antonio Ospite 2016-07-05 13:31:01 UTC

Hi,

the coordinates in mic_geometry are relative to the _center_ of the bounding box of the mic array, this is quite clear in the comments in the code (see echo-cancel/webrtc.cc::parse_mic_geometry()), but the word "center" is not present in the wiki documentation, and the first time I read the parameter description it was not immediately clear to me how to specify the coordinates:

https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/?updated#index45h3

Maybe the description can be changed like this:

...the first three numbers specify the coordinates of the first [-mic,-] {+mic relative to the "center" of the microphone array,+} and the last ...

Thanks,
   Antonio

Comment 1 Tanu Kaskinen 2016-07-05 14:36:01 UTC

Thanks! Fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.