Bug 96822 - module-echo-cancel: DOC aec_method='webrtc', mic_geometry coordinates are relative to center
Summary: module-echo-cancel: DOC aec_method='webrtc', mic_geometry coordinates are rel...
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-05 13:31 UTC by Antonio Ospite
Modified: 2016-07-05 14:36 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Antonio Ospite 2016-07-05 13:31:01 UTC
Hi,

the coordinates in mic_geometry are relative to the _center_ of the bounding box of the mic array, this is quite clear in the comments in the code (see echo-cancel/webrtc.cc::parse_mic_geometry()), but the word "center" is not present in the wiki documentation, and the first time I read the parameter description it was not immediately clear to me how to specify the coordinates:

https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/?updated#index45h3

Maybe the description can be changed like this:

...the first three numbers specify the coordinates of the first [-mic,-] {+mic relative to the "center" of the microphone array,+} and the last ...

Thanks,
   Antonio
Comment 1 Tanu Kaskinen 2016-07-05 14:36:01 UTC
Thanks! Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.