| Summary: | Fix double printing function name in _dbus_verbose() messages. | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | core | Assignee: | D-Bus Maintainers <dbus> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | CC: | ralf.habacker |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Fix double printing function name in _dbus_verbose() messages.
Fix double printing function name in _dbus_verbose() messages. |
||
|
Description
Ralf Habacker
2016-10-05 07:58:36 UTC
Created attachment 127020 [details] [review] Fix double printing function name in _dbus_verbose() messages. Comment on attachment 127020 [details] [review] Fix double printing function name in _dbus_verbose() messages. Review of attachment 127020 [details] [review]: ----------------------------------------------------------------- Fine, except that you're introducing verbose logging that wasn't previously there. ::: dbus/dbus-transport.c @@ +1145,4 @@ > { > DBusDispatchStatus status; > > + _dbus_verbose ("enter\n"); This was previously #if 0. I suspect this may have been because this function is frequently called, so it was so ridiculously verbose that it makes DBUS_VERBOSE even less useful than it already is? (In reply to Simon McVittie from comment #2) > Comment on attachment 127020 [details] [review] [review] > Fix double printing function name in _dbus_verbose() messages. > > Review of attachment 127020 [details] [review] [review]: > ----------------------------------------------------------------- > > Fine, except that you're introducing verbose logging that wasn't previously > there. > > ::: dbus/dbus-transport.c > @@ +1145,4 @@ > > { > > DBusDispatchStatus status; > > > > + _dbus_verbose ("enter\n"); > > This was previously #if 0. I suspect this may have been because this > function is frequently called, so it was so ridiculously verbose that it > makes DBUS_VERBOSE even less useful than it already is? Okay, I will wrap this hunk with #if 0 ...#endif, so that people want to debug cant change that. Created attachment 127022 [details] [review] Fix double printing function name in _dbus_verbose() messages. Bug: Attachment 127022 [details] pushed as 487a26f - Fix double printing function name in _dbus_verbose() messages.
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.