Bug 98131

Summary:	Compiler should reject lowp/mediump qualifiers on atomic_uints
Product:	Mesa	Reporter:	Kenneth Graunke <kenneth>
Component:	glsl-compiler	Assignee:	Tapani Pälli <lemody>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	94448

Description Kenneth Graunke 2016-10-07 00:31:38 UTC

dEQP-GLES31.functional.debug.negative_coverage.callbacks.atomic_counter.atomic_precision
dEQP-GLES31.functional.debug.negative_coverage.get_error.atomic_counter.atomic_precision
dEQP-GLES31.functional.debug.negative_coverage.log.atomic_counter.atomic_precision

try to compile shaders with mediump/lowp atomic_uint variables.  It expects compilation to fail, but we let it succeed.  We likely need to raise an error.

Comment 1 Tapani Pälli 2016-10-10 05:09:20 UTC

commit d997d5c0c9e9c70a95f0c84255feec8e2963ef20
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Fri Oct 7 08:23:41 2016 +0300

    glsl: prohibit lowp, mediump precision on atomic_uint
    
    Fixes following dEQP tests:
    
       dEQP-GLES31.functional.debug.negative_coverage.callbacks.atomic_counter.atomic_precision
       dEQP-GLES31.functional.debug.negative_coverage.get_error.atomic_counter.atomic_precision
       dEQP-GLES31.functional.debug.negative_coverage.log.atomic_counter.atomic_precision
    
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98131
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.