Bug 98698

Summary:	bootstrap.sh should not hardcode glibtoolize
Product:	PulseAudio	Reporter:	Philip Chimento <philip.chimento>
Component:	build-system	Assignee:	pulseaudio-bugs
Status:	RESOLVED FIXED	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Mac OS X (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch Patch

Description Philip Chimento 2016-11-12 20:55:36 UTC

bootstrap.sh hardcodes LIBTOOLIZE to "glibtoolize" on Darwin systems, regardless of whether the user has set a value for that variable already. This patch makes sure the user-set value of LIBTOOLIZE always takes priority.

(Not on every configuration is libtoolize renamed to glibtoolize; it depends how one installed their build environment.)

In my opinion it would be even better to just let libtoolize happen as part of autoreconf, which would pick up any normal overrides that the user made, same as other autotools packages; but it looks like it was set up this way purposely, and I'm not aware of the reasons, so I went for the simple fix instead.

Comment 1 Philip Chimento 2016-11-12 20:56:13 UTC

Created attachment 127940 [details] [review]
Patch

Comment 2 Tanu Kaskinen 2016-11-14 14:28:55 UTC

(In reply to Philip Chimento from comment #0)
> In my opinion it would be even better to just let libtoolize happen as part
> of autoreconf, which would pick up any normal overrides that the user made,
> same as other autotools packages; but it looks like it was set up this way
> purposely, and I'm not aware of the reasons, so I went for the simple fix
> instead.

libtoolize already happens as part of autoreconf. The LIBTOOLIZE variable stuff existed before we replaced a direct libtoolize call with autoreconf in commit 5b0aaecb0b, so this stuff is probably just some old cruft that should have been removed. Would you like to make another patch?

Comment 3 Philip Chimento 2016-11-15 04:45:21 UTC

Created attachment 127973 [details] [review]
Patch

OK, got it!

Comment 4 Tanu Kaskinen 2016-11-15 10:08:12 UTC

Thanks! I applied the patch to the "next" branch.

Comment 5 Philip Chimento 2016-11-16 04:19:57 UTC

Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.